Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23236

PatchSetCreatedEvent now has a "kind" field

XMLWordPrintable

      https://gerrit-review.googlesource.com/#/c/57231/ merged in a change to PatchSetCreatedEvent that adds a kind field and ChangeKind enum. This allows Gerrit to communicate the kind of change, and the listener to take certain actions based on this change kind.

      Example if change kind is "NO_CODE_CHANGE" (i.e. just a commit message change) then the listener could decide not to trigger a build.

      At this point, this is just a heads up, as this is in master, and not released but since it was "our" bug report that precipitated this change, we'd very much like to see this in Gerrit Trigger soon.

          [JENKINS-23236] PatchSetCreatedEvent now has a "kind" field

          rin_ne added a comment -

          Does the below fix belong to this?
          https://github.com/jenkinsci/gerrit-trigger-plugin/pull/159

          rin_ne added a comment - Does the below fix belong to this? https://github.com/jenkinsci/gerrit-trigger-plugin/pull/159

          Joshua Kugler added a comment -

          Yes, it appears that there is already code in flight to resolve this issue. I was not aware of that. Thank you for pointing it out.

          Joshua Kugler added a comment - Yes, it appears that there is already code in flight to resolve this issue. I was not aware of that. Thank you for pointing it out.

          Sebastian Schuberth added a comment -

          As mention at https://code.google.com/p/gerrit/issues/detail?id=2634 the upstream changes required for this feature will not make it into Gerrit 2.9, but probably require Gerrit 2.10.

          Sebastian Schuberth added a comment - As mention at https://code.google.com/p/gerrit/issues/detail?id=2634 the upstream changes required for this feature will not make it into Gerrit 2.9, but probably require Gerrit 2.10.

          rin_ne added a comment -

          Someone did test with Gerrit 2.10-rc0?

          rin_ne added a comment - Someone did test with Gerrit 2.10-rc0?

          Braden Anderson added a comment - - edited

          Gerrit 2.10 has now been released. This issue is mentioned in the release notes: "Issue 2634: Add change kind to PatchSetCreatedEvent."

          https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.10.html

          Braden Anderson added a comment - - edited Gerrit 2.10 has now been released. This issue is mentioned in the release notes: "Issue 2634: Add change kind to PatchSetCreatedEvent." https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.10.html

          rsandell added a comment -

          Released in Gerrit Trigger 2.12
          Available for Gerrit Server 2.10

          rsandell added a comment - Released in Gerrit Trigger 2.12 Available for Gerrit Server 2.10

            rsandell rsandell
            jkugler Joshua Kugler
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: