Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24805

Mask credentials in Build Log

XMLWordPrintable

      Accidents happen...

      It would be nice if the credentials introduced via this plugin were masked on the console output of a job log.

          [JENKINS-24805] Mask credentials in Build Log

          Jesse Glick added a comment -

          brianeray sounds like an unrelated bug which should be filed separately.

          Jesse Glick added a comment - brianeray sounds like an unrelated bug which should be filed separately.

          Brian Ray added a comment -

          jglick, thanks. It's JENKINS-34823. Entered as a Priority: minor.

          Brian Ray added a comment - jglick , thanks. It's JENKINS-34823 . Entered as a Priority: minor.

          Dan Tranter added a comment -

          Just curious if there was any recent movement or potential fix for this on credential-binding for FreeStyle jobs

          Dan Tranter added a comment - Just curious if there was any recent movement or potential fix for this on credential-binding for FreeStyle jobs

          Paul Grove added a comment -

          As this article states this is "current best-practices" maybe then some effort should be made to kill the bugs of the credential bind plugin that makes the best practice insecure. This ticket has been open for 2 years. Due to this bug the plugin is disabled in our company, leading to yet more hack workarounds that sap our time. Please fix!

          Paul Grove added a comment - As this article states this is "current best-practices" maybe then some effort should be made to kill the bugs of the credential bind plugin that makes the best practice insecure. This ticket has been open for 2 years. Due to this bug the plugin is disabled in our company, leading to yet more hack workarounds that sap our time. Please fix!

          Andrew Bayer added a comment -

          One more attempt at a PR up for review - https://github.com/jenkinsci/credentials-binding-plugin/pull/28

          Andrew Bayer added a comment - One more attempt at a PR up for review - https://github.com/jenkinsci/credentials-binding-plugin/pull/28

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a
          Log:
          JENKINS-24805 First work on masking secrets in freestyle logs.

          This still needs tests - I just want to make sure the approach is right.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a Log: JENKINS-24805 First work on masking secrets in freestyle logs. This still needs tests - I just want to make sure the approach is right.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41
          Log:
          Merge pull request #28 from abayer/jenkins-24805

          JENKINS-24805 Start masking secrets in freestyle logs.

          Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41 Log: Merge pull request #28 from abayer/jenkins-24805 JENKINS-24805 Start masking secrets in freestyle logs. Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33

          akostadinov added a comment -

          Thanks a lot for implementing this! Which version of plug-in would have these changes?

          akostadinov added a comment - Thanks a lot for implementing this! Which version of plug-in would have these changes?

          Andrew Bayer added a comment -

          It'll be in the next release, 1.10.

          Andrew Bayer added a comment - It'll be in the next release, 1.10.

          Jesse Glick added a comment -

          …which is released.

          Jesse Glick added a comment - …which is released.

            abayer Andrew Bayer
            walterk82 Walter Kacynski
            Votes:
            13 Vote for this issue
            Watchers:
            22 Start watching this issue

              Created:
              Updated:
              Resolved: