Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24805

Mask credentials in Build Log

    XMLWordPrintable

Details

    Description

      Accidents happen...

      It would be nice if the credentials introduced via this plugin were masked on the console output of a job log.

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41760 Broken output when empty secret

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28219 After entering a username/password combo in Credentials Binding, I can print out the value of the password inside a Jenkins job

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-31985 mask passwords from Credentials Binding Plugin

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 12

          Web Link PR 19

          Web Link PR #28

          Activity

            Ascending order - Click to sort in descending order
            View 13 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
            http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a
            Log:
            JENKINS-24805 First work on masking secrets in freestyle logs.

            This still needs tests - I just want to make sure the approach is right.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a Log: JENKINS-24805 First work on masking secrets in freestyle logs. This still needs tests - I just want to make sure the approach is right.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
            src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java
            http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41
            Log:
            Merge pull request #28 from abayer/jenkins-24805

            JENKINS-24805 Start masking secrets in freestyle logs.

            Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41 Log: Merge pull request #28 from abayer/jenkins-24805 JENKINS-24805 Start masking secrets in freestyle logs. Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33
            akostadinov akostadinov added a comment -

            Thanks a lot for implementing this! Which version of plug-in would have these changes?

            akostadinov akostadinov added a comment - Thanks a lot for implementing this! Which version of plug-in would have these changes?
            abayer Andrew Bayer added a comment -

            It'll be in the next release, 1.10.

            abayer Andrew Bayer added a comment - It'll be in the next release, 1.10.
            jglick Jesse Glick added a comment -

            …which is released.

            jglick Jesse Glick added a comment - …which is released.

            People

              abayer Andrew Bayer
              walterk82 Walter Kacynski
              Votes:
              13 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: