Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41760

Broken output when empty secret

XMLWordPrintable

      when I try to inject a password credential as a environment variable into my build the console log gets unreadable and looks like:

      ****[****b****u****i****l****d****d****e****b****u****g****]**** ****$**** ****/****b****i****n****/****s****h**** ****-****x****e**** ****/****v****a****r****/****f****o****l****d****e****r****s****/****3****n****/****k****x****0****t****1****c****5****n****6****k****x****1****q****k****7****z****6****g****x****z****b****r****m****m****0****0****0****0****g****q****/****T****/****h****u****d****s****o****n****6****1****3****3****8****8****6****3****4****5****6****2****6****3****9****9****3****6****7****.****s****h****
********+**** ****r****u****b****y**** ****-****v****
********r****u****b****y**** ****2****.****4****.****0****p****0**** ****(****2****0****1****6****-****1****2****-****2****4**** ****r****e****v****i****s****i****o****n**** ****5****7****1****6****4****)**** ****[****x****8****6****_****6****4****-****d****a****r****w****i****n****1****5****]****
********+**** ****b****u****n****d****l****e**** ****-****v****
********B****u****n****d****l****e****r**** ****v****e****r****s****i****o****n**** ****1****.****1****4****.****3****
********+**** ****e****n****v****

          [JENKINS-41760] Broken output when empty secret

          Thomas Einwaller added a comment -

          I found the reason: the injected credentials only have a password and no username - when adding something as username, even when not using it everything works as expected - must have something to do with the changes introduced in 1.10 for https://issues.jenkins-ci.org/browse/JENKINS-24805

          Thomas Einwaller added a comment - I found the reason: the injected credentials only have a password and no username - when adding something as username, even when not using it everything works as expected - must have something to do with the changes introduced in 1.10 for https://issues.jenkins-ci.org/browse/JENKINS-24805

          Michal Slusarczyk added a comment -

          I proposed a fix here: https://github.com/jenkinsci/credentials-binding-plugin/pull/35

          Michal Slusarczyk added a comment - I proposed a fix here: https://github.com/jenkinsci/credentials-binding-plugin/pull/35

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Slusarczyk
          Path:
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/6a7a80641ef7821c3fd061522cc4b3dbb9e25563
          Log:
          JENKINS-41760 Broken output when empty secret - check for empty secrets during pattern creation

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Slusarczyk Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java http://jenkins-ci.org/commit/credentials-binding-plugin/6a7a80641ef7821c3fd061522cc4b3dbb9e25563 Log: JENKINS-41760 Broken output when empty secret - check for empty secrets during pattern creation

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/f982299fc51ff205a2d3a4be861b14abd4142edc
          Log:
          JENKINS-41760 Reproduced bad output in test: blank (but not empty) creds for freestyle; blank or empty for Pipeline.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/f982299fc51ff205a2d3a4be861b14abd4142edc Log: JENKINS-41760 Reproduced bad output in test: blank (but not empty) creds for freestyle; blank or empty for Pipeline.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/7aa3871509767bf65c8084402f61ac3a222f83d1
          Log:
          Merge pull request #43 from jglick/empty-secret-JENKINS-41760

          JENKINS-41760 Suppress masking of blank secrets

          Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/b141c6fae490...7aa387150976

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/7aa3871509767bf65c8084402f61ac3a222f83d1 Log: Merge pull request #43 from jglick/empty-secret- JENKINS-41760 JENKINS-41760 Suppress masking of blank secrets Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/b141c6fae490...7aa387150976

            mslusarczyk Michal Slusarczyk
            einwaller Thomas Einwaller
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: