-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
Powered by SuggestiMate
- is blocking
-
JENKINS-25380 Allow parameterizing vSphere host and credentials via external file
-
- Closed
-
- links to
[JENKINS-25588] Integrate vSphere Cloud plugin with Credentials plugin (auth options)
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/vSphereCloud.java
src/main/java/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig.java
src/main/resources/org/jenkinsci/plugins/vSphereCloud/config.jelly
src/main/resources/org/jenkinsci/plugins/vSphereCloud/help-vsHost.html
src/main/resources/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig/config.groovy
src/main/resources/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig/help-vsHost.html
http://jenkins-ci.org/commit/vsphere-cloud-plugin/5d7242aa672e31c015f0e0c0e3bffa4e05b37a27
Log:
JENKINS-25588 - Migrate vSphereCloud to Credentials plugin
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Code changed in jenkins
User: Jason Swager
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/vSphereCloud.java
src/main/java/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig.java
src/main/resources/org/jenkinsci/plugins/vSphereCloud/config.jelly
src/main/resources/org/jenkinsci/plugins/vSphereCloud/help-vsHost.html
src/main/resources/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig/config.groovy
src/main/resources/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig/help-vsHost.html
http://jenkins-ci.org/commit/vsphere-cloud-plugin/aca23f66385d2acdb243eb901472cf9c158ae606
Log:
Merge pull request #16 from oleg-nenashev/JENKINS-25588
JENKINS-25588 - Migrate vSphereCloud to Credentials plugin
Compare: https://github.com/jenkinsci/vsphere-cloud-plugin/compare/82af1af0128f...aca23f66385d
Looks to be a few issues with this update.
Upgraded to this plugin today. All I get is the following. In the main Jenkins Configuration page, after adding a credential for the VM server and hitting Text Connection:
"Username is not specified"
When trying to launch a slave:
javax.servlet.ServletException: java.lang.RuntimeException: org.jenkinsci.plugins.vsphere.tools.VSphereException: java.net.MalformedURLException: no protocol: null/sdk
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:796)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
at org.kohsuke.stapler.MetaClass$6.doDispatch(MetaClass.java:249)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:686)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1494)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:96)
at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:58)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:99)
at com.marvelution.jenkins.plugins.jira.filter.ApplinksServletFilter.doFilter(ApplinksServletFilter.java:83)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:99)
at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:88)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:48)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:81)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:533)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
at org.eclipse.jetty.server.Server.handle(Server.java:370)
at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:960)
at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1021)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)
at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:668)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:701)
Caused by: java.lang.RuntimeException: org.jenkinsci.plugins.vsphere.tools.VSphereException: java.net.MalformedURLException: no protocol: null/sdk
at org.jenkinsci.plugins.vSphereCloudSlave$DescriptorImpl.doTestConnection(vSphereCloudSlave.java:437)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:622)
at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:298)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:161)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:96)
at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:121)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
... 67 more
Caused by: org.jenkinsci.plugins.vsphere.tools.VSphereException: java.net.MalformedURLException: no protocol: null/sdk
at org.jenkinsci.plugins.vsphere.tools.VSphere.<init>(VSphere.java:44)
at org.jenkinsci.plugins.vsphere.tools.VSphere.connect(VSphere.java:57)
at org.jenkinsci.plugins.vSphereCloud.vSphereInstance(vSphereCloud.java:156)
at org.jenkinsci.plugins.vSphereCloudSlave$DescriptorImpl.doTestConnection(vSphereCloudSlave.java:423)
... 77 more
Caused by: java.net.MalformedURLException: no protocol: null/sdk
at java.net.URL.<init>(URL.java:585)
at java.net.URL.<init>(URL.java:482)
at java.net.URL.<init>(URL.java:431)
at org.jenkinsci.plugins.vsphere.tools.VSphere.<init>(VSphere.java:41)
... 80 more
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/resources/org/jenkinsci/plugins/vSphereCloud/config.jelly
http://jenkins-ci.org/commit/vsphere-cloud-plugin/3667afe1236c896b389fcdd043180cc063a7d298
Log:
JENKINS-25588 - Fixed the "Test Connection" validation handler
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/vSphereCloud.java
http://jenkins-ci.org/commit/vsphere-cloud-plugin/4d74a1d4b274495e3d56b63b3ef0a8ef39beae8b
Log:
JENKINS-25588 - Fix the error with vSphereInstance() setup.
I forgot to remove vcHost usage in previous commits.
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/vSphereCloud.java
src/main/java/org/jenkinsci/plugins/vsphere/tools/VSphere.java
http://jenkins-ci.org/commit/vsphere-cloud-plugin/7a73a674e3424cadd84dbcc99b61d2c66a6659c4
Log:
JENKINS-25588 - Improve error checks for missing host/username
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Compare: https://github.com/jenkinsci/vsphere-cloud-plugin/compare/3667afe1236c^...7a73a674e342
Code changed in jenkins
User: Jason Swager
Path:
src/main/java/org/jenkinsci/plugins/vSphereCloud.java
src/main/java/org/jenkinsci/plugins/vsphere/tools/VSphere.java
src/main/resources/org/jenkinsci/plugins/vSphereCloud/config.jelly
http://jenkins-ci.org/commit/vsphere-cloud-plugin/db8104dd3e879927c4811a32e2c749fe4984701a
Log:
Merge pull request #18 from oleg-nenashev/JENKINS-25588
JENKINS-25588 - Fixed the "Test Connection" validation handler
Compare: https://github.com/jenkinsci/vsphere-cloud-plugin/compare/0f17d4b0ed4b...db8104dd3e87
This feature is required to avoid keeping credentials in Node/Cloud configuration files.
In our company passwords have a limited lifetime, so it becomes a mess