Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26583

Env-inject plugin suppress variables contributed by extension points

    XMLWordPrintable

Details

    Description

      Whenever envvar is available on slave (either inherited from system or configured on slave), its value can not be overridden during build by envvar contributing extension points:

      • EnvironmentContributor
      • BuildWrapper
      • possibly others

      This works correctly when envinject is not installed. The culprit seemsto be that EnvInjectPluginAction retains all envvars (not only those envinject contributed) early in the build and put this values back as it implements EnvironmentContributingAction. Any value that was overridden by a plugin is then reset to its original value.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27170 "Provide Node & npm bin/ folder to PATH" not working for "npm install"

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20177 XVnc plugin fails to set the DISPLAY variable properly if jenkins already

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25839 $BEAKER_JOB_ID expanded to wrong value

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23639 EnvInject squelches changes to $BUILD_DISPLAY_NAME made by build name setter plugin

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-43593 NPM unable to locate node binary

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26302 REGRESSION: Node environment doesn't work

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-24406 'Inject variables as a build step' resets slave's system path

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42323 NodeJS plugin 1.1.2 -- PATH not including node + npm

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42212 Incompatibility with EnvInject plugin

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25946 Build environment contributed by extension points can override characteristic env-vars

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41762 NodeJS plugin not updating PATH as expected

          • Major - Major loss of function.
          • Closed
          links to

          Web Link https://github.com/jenkinsci/envinject-plugin/pull/124

          Web Link https://github.com/jenkinsci/envinject-plugin/pull/125

          Web Link Reproducer PR#37

          Activity

            Ascending order - Click to sort in descending order
            View 38 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
            src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java
            src/test/java/org/jenkinsci/plugins/envinject/EnvInjectActionTest.java
            http://jenkins-ci.org/commit/envinject-plugin/2948c711b05b68c6a94c334c26fe4e6fdcecda9f
            Log:
            [FIXED JENKINS-26583] Do not capture slave variables

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectActionTest.java http://jenkins-ci.org/commit/envinject-plugin/2948c711b05b68c6a94c334c26fe4e6fdcecda9f Log: [FIXED JENKINS-26583] Do not capture slave variables
            oleg_nenashev Oleg Nenashev added a comment -

            I hope to release the fix on this weekend

            oleg_nenashev Oleg Nenashev added a comment - I hope to release the fix on this weekend
            oleg_nenashev Oleg Nenashev added a comment -

            the fix has been released in 2.1.4

            oleg_nenashev Oleg Nenashev added a comment - the fix has been released in 2.1.4
            apxeolog Artyom Melnikov added a comment -

            There is still an issue with plugin overriding env variables even if it is disabled (meaning not enabled in the project configuration). And PATH property still fully changed. I suggest to merge PATH property instead of overriding it (split both PATH's to elements and merge into Set)

            apxeolog Artyom Melnikov added a comment - There is still an issue with plugin overriding env variables even if it is disabled (meaning not enabled in the project configuration). And PATH property still fully changed. I suggest to merge PATH property instead of overriding it (split both PATH's to elements and merge into Set)
            oleg_nenashev Oleg Nenashev added a comment -

            > I suggest to merge PATH property instead of overriding it (split both PATH's to elements and merge into Set)

            I will be happy to review a pull request for that.
            It's not that trivial in the code though

            oleg_nenashev Oleg Nenashev added a comment - > I suggest to merge PATH property instead of overriding it (split both PATH's to elements and merge into Set) I will be happy to review a pull request for that. It's not that trivial in the code though

            People

              oleg_nenashev Oleg Nenashev
              olivergondza Oliver Gondža
              Votes:
              47 Vote for this issue
              Watchers:
              66 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: