Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26643

DescribableList.buildDependencyGraph should catch RuntimeException

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      If a DependencyDeclarer throws a RuntimeException from buildDependencyGraph, it can prevent Jenkins from starting.

      This could happen simply because a project has an invalid configuration, such as in the parameterized trigger plugin.

      Example:

      SEVERE: Failed Finalizing set up
      java.lang.NullPointerException
      at java.util.StringTokenizer.<init>(Unknown Source)
      at java.util.StringTokenizer.<init>(Unknown Source)
      at hudson.model.Items.fromNameList(Items.java:145)
      at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getProjectList(BuildTriggerConfig.java:125)
      at hudson.plugins.parameterizedtrigger.BuildTrigger.buildDependencyGraph(BuildTrigger.java:74)
      at hudson.util.DescribableList.buildDependencyGraph(DescribableList.java:213)
      at hudson.model.Project.buildDependencyGraph(Project.java:201)
      at hudson.model.DependencyGraph.build(DependencyGraph.java:95)
      at jenkins.model.Jenkins.rebuildDependencyGraph(Jenkins.java:3738)
      at jenkins.model.Jenkins$20.run(Jenkins.java:2680)
      at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
      at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
      at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
      at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
      at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
      at java.lang.Thread.run(Unknown Source)

          [JENKINS-26643] DescribableList.buildDependencyGraph should catch RuntimeException

          Code changed in jenkins
          User: Ryan Campbell
          Path:
          core/src/main/java/hudson/util/DescribableList.java
          http://jenkins-ci.org/commit/jenkins/7f7db958c21b39d29b77c8a186a94fb83f0a30f2
          Log:
          JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/util/DescribableList.java http://jenkins-ci.org/commit/jenkins/7f7db958c21b39d29b77c8a186a94fb83f0a30f2 Log: JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException

          Code changed in jenkins
          User: Ryan Campbell
          Path:
          core/src/main/java/hudson/util/DescribableList.java
          http://jenkins-ci.org/commit/jenkins/c66ad897fed39d33f470267e4ed7244298157a31
          Log:
          Merge pull request #1550 from recampbell/JENKINS-26643

          JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException

          Compare: https://github.com/jenkinsci/jenkins/compare/2b1ef0bf94dd...c66ad897fed3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/util/DescribableList.java http://jenkins-ci.org/commit/jenkins/c66ad897fed39d33f470267e4ed7244298157a31 Log: Merge pull request #1550 from recampbell/ JENKINS-26643 JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException Compare: https://github.com/jenkinsci/jenkins/compare/2b1ef0bf94dd...c66ad897fed3

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3956
          JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException (Revision 7f7db958c21b39d29b77c8a186a94fb83f0a30f2)

          Result = SUCCESS
          ryan campbell : 7f7db958c21b39d29b77c8a186a94fb83f0a30f2
          Files :

          • core/src/main/java/hudson/util/DescribableList.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3956 JENKINS-26643 DescribableList.buildDependencyGraph should catch RuntimeException (Revision 7f7db958c21b39d29b77c8a186a94fb83f0a30f2) Result = SUCCESS ryan campbell : 7f7db958c21b39d29b77c8a186a94fb83f0a30f2 Files : core/src/main/java/hudson/util/DescribableList.java

            recampbell Ryan Campbell
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: