Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26684

Maven build step fail to launch mvn process when special chars are present in build variables

      Maven build step put all build variables on command line as properties. This causes problems when special characters are used. This happens often when non-trivial label expressions are used: -Dlabel_exp=w2k8&&x86.

          [JENKINS-26684] Maven build step fail to launch mvn process when special chars are present in build variables

          Oliver Gondža created issue -

          Daniel Beck added a comment -

          Passing all build parameters this way is a horrible idea anyway, but it's probably too late to do anything about it.

          Daniel Beck added a comment - Passing all build parameters this way is a horrible idea anyway, but it's probably too late to do anything about it.

          Oliver Gondža added a comment - Fix proposed: https://github.com/jenkinsci/jenkins/pull/1556

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          test/src/test/java/hudson/tasks/MavenTest.java
          http://jenkins-ci.org/commit/jenkins/fae41b01c9c034ab98216c92ca6bd171b8d81d6b
          Log:
          JENKINS-26684 Reproduce in unittest.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: test/src/test/java/hudson/tasks/MavenTest.java http://jenkins-ci.org/commit/jenkins/fae41b01c9c034ab98216c92ca6bd171b8d81d6b Log: JENKINS-26684 Reproduce in unittest.

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/tasks/Maven.java
          http://jenkins-ci.org/commit/jenkins/58a41bcb182290de681da01ba277b5e0d6211707
          Log:
          [FIXED JENKINS-26684] Escape special chars in maven build step arguments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/tasks/Maven.java http://jenkins-ci.org/commit/jenkins/58a41bcb182290de681da01ba277b5e0d6211707 Log: [FIXED JENKINS-26684] Escape special chars in maven build step arguments
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/tasks/Maven.java
          test/src/test/java/hudson/tasks/MavenTest.java
          http://jenkins-ci.org/commit/jenkins/66b62b9a1f9b68ef5e61304c6aff6e1bef37514e
          Log:
          Merge pull request #1567 from olivergondza/maven-special-chars-dirty

          JENKINS-26684 Escape special chars in maven build step arguments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/tasks/Maven.java test/src/test/java/hudson/tasks/MavenTest.java http://jenkins-ci.org/commit/jenkins/66b62b9a1f9b68ef5e61304c6aff6e1bef37514e Log: Merge pull request #1567 from olivergondza/maven-special-chars-dirty JENKINS-26684 Escape special chars in maven build step arguments

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3972
          JENKINS-26684 Reproduce in unittest. (Revision fae41b01c9c034ab98216c92ca6bd171b8d81d6b)
          [FIXED JENKINS-26684] Escape special chars in maven build step arguments (Revision 58a41bcb182290de681da01ba277b5e0d6211707)

          Result = SUCCESS
          ogondza : fae41b01c9c034ab98216c92ca6bd171b8d81d6b
          Files :

          • test/src/test/java/hudson/tasks/MavenTest.java

          ogondza : 58a41bcb182290de681da01ba277b5e0d6211707
          Files :

          • core/src/main/java/hudson/tasks/Maven.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3972 JENKINS-26684 Reproduce in unittest. (Revision fae41b01c9c034ab98216c92ca6bd171b8d81d6b) [FIXED JENKINS-26684] Escape special chars in maven build step arguments (Revision 58a41bcb182290de681da01ba277b5e0d6211707) Result = SUCCESS ogondza : fae41b01c9c034ab98216c92ca6bd171b8d81d6b Files : test/src/test/java/hudson/tasks/MavenTest.java ogondza : 58a41bcb182290de681da01ba277b5e0d6211707 Files : core/src/main/java/hudson/tasks/Maven.java
          Oliver Gondža made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.596.2-fixed windows

            Unassigned Unassigned
            olivergondza Oliver Gondža
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: