Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26698

Failure to recover from exception in Publisher.needsToRunAfterFinalized

      If Publisher.needsToRunAfterFinalized throws an exception, the workspace lease is not released.

      Worse, the exception is not even reported anywhere if there was already an exception in the publisher, because Run.handleFatalBuildProblem closed the build log the first time, so the stack trace is lost.

          [JENKINS-26698] Failure to recover from exception in Publisher.needsToRunAfterFinalized

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Run.java
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/62af87b67a1097376b9af554421e621d32f7013f
          Log:
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease.
          Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/62af87b67a1097376b9af554421e621d32f7013f Log: JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/slaves/WorkspaceList.java
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/1f844a55222c4442102d06f37c205f1819e2ce2f
          Log:
          [FiXED JENKINS-26698] Noting merge of #1554.

          Compare: https://github.com/jenkinsci/jenkins/compare/7ad3f5012156...1f844a55222c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/slaves/WorkspaceList.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/1f844a55222c4442102d06f37c205f1819e2ce2f Log: [FiXED JENKINS-26698] Noting merge of #1554. Compare: https://github.com/jenkinsci/jenkins/compare/7ad3f5012156...1f844a55222c

          Jesse Glick added a comment -

          JIRA link daemon heed my cries!

          Jesse Glick added a comment - JIRA link daemon heed my cries!

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3960
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 62af87b67a1097376b9af554421e621d32f7013f)

          Result = SUCCESS
          jesse glick : 62af87b67a1097376b9af554421e621d32f7013f
          Files :

          • core/src/main/java/hudson/model/Build.java
          • core/src/main/java/hudson/model/Run.java
          • test/src/test/java/hudson/model/BuildExecutionTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3960 JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 62af87b67a1097376b9af554421e621d32f7013f) Result = SUCCESS jesse glick : 62af87b67a1097376b9af554421e621d32f7013f Files : core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Run.java
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/7e72e7d1218e3443650d8d0c1e20b70d558422b0
          Log:
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease.
          Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.
          (cherry picked from commit 62af87b67a1097376b9af554421e621d32f7013f)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/7e72e7d1218e3443650d8d0c1e20b70d558422b0 Log: JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too. (cherry picked from commit 62af87b67a1097376b9af554421e621d32f7013f)

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Build.java
          core/src/main/resources/hudson/model/Messages.properties
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b
          Log:
          JENKINS-26698 Localization as suggested by @daniel-beck.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b Log: JENKINS-26698 Localization as suggested by @daniel-beck.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/Build.java
          core/src/main/resources/hudson/model/Messages.properties
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/776380ff4efa46c5afa6850dbca810f333039a40
          Log:
          Merge pull request #1635 from jglick/l10n-JENKINS-26698

          JENKINS-26698 Localization follow-up

          Compare: https://github.com/jenkinsci/jenkins/compare/a976bdcf64a8...776380ff4efa

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/776380ff4efa46c5afa6850dbca810f333039a40 Log: Merge pull request #1635 from jglick/l10n- JENKINS-26698 JENKINS-26698 Localization follow-up Compare: https://github.com/jenkinsci/jenkins/compare/a976bdcf64a8...776380ff4efa

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4060
          JENKINS-26698 Localization as suggested by @daniel-beck. (Revision f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b)

          Result = SUCCESS
          jesse glick : f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b
          Files :

          • core/src/main/java/hudson/model/Build.java
          • core/src/main/resources/hudson/model/Messages.properties
          • test/src/test/java/hudson/model/BuildExecutionTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4060 JENKINS-26698 Localization as suggested by @daniel-beck. (Revision f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b) Result = SUCCESS jesse glick : f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b Files : core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 7e72e7d1218e3443650d8d0c1e20b70d558422b0)

          Result = UNSTABLE
          ogondza : 7e72e7d1218e3443650d8d0c1e20b70d558422b0
          Files :

          • core/src/main/java/hudson/model/Build.java
          • test/src/test/java/hudson/model/BuildExecutionTest.java
          • core/src/main/java/hudson/model/Run.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 7e72e7d1218e3443650d8d0c1e20b70d558422b0) Result = UNSTABLE ogondza : 7e72e7d1218e3443650d8d0c1e20b70d558422b0 Files : core/src/main/java/hudson/model/Build.java test/src/test/java/hudson/model/BuildExecutionTest.java core/src/main/java/hudson/model/Run.java

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: