Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26824

Easy to accidentally modify wrong user using many plugins and many users

      Root problem:

      Global permission matrix too wide to show leftmost username when using right most toggle permissions or delete user buttons.
      This applies for a large number of usernames and plugins that require permissions.

      Example usecases:

      • It is too easy (relative to the consequences) to accidentally toggle all permissions for "Anonymous" when creating a new user, as both are normally sorted last. This would be really bad for an internet exposed Jenkins installation.
      • It is too easy to accidentally delete the wrong user (red X rightmost).

      Suggested improvements:

      • tr.permission-row:hover { background: #999999; }
      • Some sort of unobtrusive popup display of username and permission name affected when hovering over checkbox, delete or "toggle permissions" in matrix.
      • Name column duplicated to the right.
      • Remove toggle permissions for the "Anonymous" user. Or at least popup a confirmation box just for "Anonymous".

          [JENKINS-26824] Easy to accidentally modify wrong user using many plugins and many users

          Clarification: Too easy to make mistakes relative to the potential consequences.

          Thomas Herrlin added a comment - Clarification: Too easy to make mistakes relative to the potential consequences.

          Daniel Beck added a comment -

          accidentally toggle all permissions for "Anonymous" when creating a new user, as both are normally sorted last.

          Improved in https://github.com/jenkinsci/matrix-auth-plugin/pull/29: authenticated and anonymous are now always the first two entries, so new users are elsewhere

           too easy to accidentally delete the wrong user (red X rightmost).

          Resolved with tool tip indicating what user, and what action/permission in https://github.com/jenkinsci/matrix-auth-plugin/pull/30

           

           

          Daniel Beck added a comment - accidentally toggle all permissions for "Anonymous" when creating a new user, as both are normally sorted last. Improved in https://github.com/jenkinsci/matrix-auth-plugin/pull/29 : authenticated and anonymous are now always the first two entries, so new users are elsewhere  too easy to accidentally delete the wrong user (red X rightmost). Resolved with tool tip indicating what user, and what action/permission in https://github.com/jenkinsci/matrix-auth-plugin/pull/30    

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.jelly
          src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.properties
          http://jenkins-ci.org/commit/matrix-auth-plugin/d6612e33f74101ce6270ec354ae9902a0cac6acd
          Log:
          JENKINS-26824 Add tooltips for actions and checkboxes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.jelly src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.properties http://jenkins-ci.org/commit/matrix-auth-plugin/d6612e33f74101ce6270ec354ae9902a0cac6acd Log: JENKINS-26824 Add tooltips for actions and checkboxes

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.jelly
          src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.properties
          http://jenkins-ci.org/commit/matrix-auth-plugin/cb0f58300f025c8fef65157b672f5e6ba743ebdc
          Log:
          Merge pull request #30 from daniel-beck/JENKINS-26824

          JENKINS-26824 Add tooltips for actions and checkboxes

          Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/8e84d0ffbee3...cb0f58300f02

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.jelly src/main/resources/hudson/security/GlobalMatrixAuthorizationStrategy/config.properties http://jenkins-ci.org/commit/matrix-auth-plugin/cb0f58300f025c8fef65157b672f5e6ba743ebdc Log: Merge pull request #30 from daniel-beck/ JENKINS-26824 JENKINS-26824 Add tooltips for actions and checkboxes Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/8e84d0ffbee3...cb0f58300f02

          Daniel Beck added a comment -

          Resolved towards matrix-auth 1.8

          Daniel Beck added a comment - Resolved towards matrix-auth 1.8

            danielbeck Daniel Beck
            thomas_herrlin Thomas Herrlin
            Votes:
            4 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: