Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27549

Job loading can be broken by a NPE in a build trigger

      AbstractProject.onLoad() is failing to catch runtime exceptions from Trigger.start(). A bug in a plugin can therefore break job loading, like in JENKINS-27438

          [JENKINS-27549] Job loading can be broken by a NPE in a build trigger

          Jesse Glick added a comment -

          Was forgotten in JENKINS-22811.

          Jesse Glick added a comment - Was forgotten in JENKINS-22811 .

          Code changed in jenkins
          User: Yoann Dubreuil
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
          test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml
          http://jenkins-ci.org/commit/jenkins/4c0d3ac6230300c369bc68878ea32c33a23c399a
          Log:
          [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit)
          Squashed commits:
          [73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/model/AbstractProject.java test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml http://jenkins-ci.org/commit/jenkins/4c0d3ac6230300c369bc68878ea32c33a23c399a Log: [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) Squashed commits: [73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger

          Oleg Nenashev added a comment -

          Marked the issue as lts-candidate

          Oleg Nenashev added a comment - Marked the issue as lts-candidate

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4159
          [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) (Revision 4c0d3ac6230300c369bc68878ea32c33a23c399a)

          Result = SUCCESS
          o.v.nenashev : 4c0d3ac6230300c369bc68878ea32c33a23c399a
          Files :

          • test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml
          • test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
          • core/src/main/java/hudson/model/AbstractProject.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4159 [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) (Revision 4c0d3ac6230300c369bc68878ea32c33a23c399a) Result = SUCCESS o.v.nenashev : 4c0d3ac6230300c369bc68878ea32c33a23c399a Files : test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml test/src/test/groovy/hudson/model/AbstractProjectTest.groovy core/src/main/java/hudson/model/AbstractProject.java

          Code changed in jenkins
          User: Yoann Dubreuil
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
          test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml
          http://jenkins-ci.org/commit/jenkins/acf716af98076d20979baafca0e47d3c2442eab0
          Log:
          [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit)
          Squashed commits:
          [73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger

          (cherry picked from commit 4c0d3ac6230300c369bc68878ea32c33a23c399a)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/model/AbstractProject.java test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml http://jenkins-ci.org/commit/jenkins/acf716af98076d20979baafca0e47d3c2442eab0 Log: [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) Squashed commits: [73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger (cherry picked from commit 4c0d3ac6230300c369bc68878ea32c33a23c399a)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) (Revision acf716af98076d20979baafca0e47d3c2442eab0)

          Result = UNSTABLE
          ogondza : acf716af98076d20979baafca0e47d3c2442eab0
          Files :

          • test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
          • core/src/main/java/hudson/model/AbstractProject.java
          • test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit) (Revision acf716af98076d20979baafca0e47d3c2442eab0) Result = UNSTABLE ogondza : acf716af98076d20979baafca0e47d3c2442eab0 Files : test/src/test/groovy/hudson/model/AbstractProjectTest.groovy core/src/main/java/hudson/model/AbstractProject.java test/src/test/resources/hudson/model/AbstractProjectTest/npeTrigger.xml

            ydubreuil Yoann Dubreuil
            ydubreuil Yoann Dubreuil
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: