Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28655

Make Docker Traceability tolerant against FingerprintCleanupThread

XMLWordPrintable

      FingerprintCleanupThread may delete fingerprints if there is no references to jobs.

      • [DECLINED] For old cores it is required to create an artificial project, which would reference builds on-demand. Such project would also allow to manage fingerprints from its interface.
      • We should add an extension point, which would allow to prohibit the Fingerprint deletion

      Old discussion summary:

      • Container fingerprints are not protected from fingerprint cleanup by the core due to the missing build references
      • I've never seen the Traceability fingerprints cleanup, but it may happen according to the Jenkins core code
      • FingerprintsCleanupThread should run randomly with one day interval according to the code

          [JENKINS-28655] Make Docker Traceability tolerant against FingerprintCleanupThread

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerEventsListenerImpl.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityHelper.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerDeploymentRefFacet.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerInspectImageFacet.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun.java
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob/sidepanel.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/index.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/main.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/sidepanel.jelly
          http://jenkins-ci.org/commit/docker-traceability-plugin/763590ad54aad7d58f96fa3cad99d0b708bcc155
          Log:
          JENKINS-28655 - Skeleton of the docker traceability manager item

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerEventsListenerImpl.java src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityHelper.java src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerDeploymentRefFacet.java src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerInspectImageFacet.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun.java src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob/sidepanel.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/index.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/main.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/sidepanel.jelly http://jenkins-ci.org/commit/docker-traceability-plugin/763590ad54aad7d58f96fa3cad99d0b708bcc155 Log: JENKINS-28655 - Skeleton of the docker traceability manager item

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityHelper.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityReportListenerImpl.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerDeploymentRefFacet.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerInspectImageFacet.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun.java
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob/sidepanel.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/index.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/main.jelly
          src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/sidepanel.jelly
          http://jenkins-ci.org/commit/docker-traceability-plugin/215f719ca9c6f44019b499dac55b22877008014b
          Log:
          Merge branch 'JENKINS-28655-handle-cleanup' into JENKINS-28656

          Conflicts:
          src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityHelper.java src/main/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityReportListenerImpl.java src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerDeploymentRefFacet.java src/main/java/org/jenkinsci/plugins/docker/traceability/fingerprint/DockerInspectImageFacet.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun.java src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob/sidepanel.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/index.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/main.jelly src/main/resources/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceRun/sidepanel.jelly http://jenkins-ci.org/commit/docker-traceability-plugin/215f719ca9c6f44019b499dac55b22877008014b Log: Merge branch ' JENKINS-28655 -handle-cleanup' into JENKINS-28656 Conflicts: src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java
          http://jenkins-ci.org/commit/docker-traceability-plugin/2ee1c9dfc567e41b04a43c6b52c62cb600c5f188
          Log:
          JENKINS-28655 - Fix the map key

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java http://jenkins-ci.org/commit/docker-traceability-plugin/2ee1c9dfc567e41b04a43c6b52c62cb600c5f188 Log: JENKINS-28655 - Fix the map key

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java
          src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java
          http://jenkins-ci.org/commit/docker-traceability-plugin/2e9ac80b99cf0a07359ae0d1ff4abe76449f3b88
          Log:
          JENKINS-28655 - Create DockerBuildReferenceJob on-demand + javadoc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceFactory.java src/main/java/org/jenkinsci/plugins/docker/traceability/model/jobs/DockerBuildReferenceJob.java http://jenkins-ci.org/commit/docker-traceability-plugin/2e9ac80b99cf0a07359ae0d1ff4abe76449f3b88 Log: JENKINS-28655 - Create DockerBuildReferenceJob on-demand + javadoc

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java
          src/test/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPluginTest.java
          src/test/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityRootActionTest.java
          http://jenkins-ci.org/commit/docker-traceability-plugin/f064f58a353a1f8e13c5e55accf88e170490c353
          Log:
          Unit tests for JENKINS-28655 and JENKINS-28656

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPlugin.java src/test/java/org/jenkinsci/plugins/docker/traceability/DockerTraceabilityPluginTest.java src/test/java/org/jenkinsci/plugins/docker/traceability/core/DockerTraceabilityRootActionTest.java http://jenkins-ci.org/commit/docker-traceability-plugin/f064f58a353a1f8e13c5e55accf88e170490c353 Log: Unit tests for JENKINS-28655 and JENKINS-28656

          Oleg Nenashev added a comment -

          I do not work on it anymore. The previous approach has been rejected by code reviewers

          Oleg Nenashev added a comment - I do not work on it anymore. The previous approach has been rejected by code reviewers

            ataylor Alex Taylor
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: