[JENKINS-28781] bytecode-compatibility-transformer produces malformed bytecode - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core
Labels:
- bytecode-compatibility-transformer

Similar Issues:

Show

Description

In the case where we see this issue, an @AdaptField annotation on Queue.Item was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

this issue tracks the tracks:

- bytecode-compatibility-transformer doesn't properly support updating of StackMapFrames after manipulation.

Attachments

Issue Links

is duplicated by

JENKINS-30665 JDK 7 (or above) compiled classes cannot be used with Jenkins 1.601 and above

Resolved

is related to

JENKINS-19383 Bytecode compatibility transformer mistakenly corrupts org.apache.ivy.core.settings.IvySettings.triggers

Resolved

JENKINS-28799 bytecode-compatibility-transformer transforming methods/fields it should not be transforming

Resolved

JENKINS-29692 targetCompatibility Gradle setting is ignored by Gradle JPI plugin and default Java is used

Closed

JENKINS-30820 plugin failures after upgrade of bytecode-compatability-transformer

Closed

Activity

Ascending order - Click to sort in descending order

Tom FENNELLY created issue - 2015-06-06 09:11

Tom FENNELLY made changes - 2015-06-08 08:04

Field	Original Value	New Value
Description	In the case where we see this issue, an [@AdaptField annotation on Queue.Item\|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing a transformation in a different class (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error. So there may actually be 2 or 3 bugs that need to be spun out from this: # The bytecode transformer is transforming methods/fields that it should not be transforming. # And one or both of the following: #* Jenkins core use of the bytecode transformer is not specifying to update StackMapFrame after transformations/rewrites. #* bytecode transformer is not performing StackMapFrame updates after transformations/rewrites.	In the case where we see this issue, an [@AdaptField annotation on Queue.Item\|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error. So there may actually be 2 or 3 bugs that need to be spun out from this: # The bytecode transformer is transforming methods/fields that it should not be transforming. # And one or both of the following: #* Jenkins core use of the bytecode transformer is not specifying to update StackMapFrame after transformations/rewrites. #* bytecode transformer is not performing StackMapFrame updates after transformations/rewrites.

Tom FENNELLY made changes - 2015-06-08 08:08

Description

In the case where we see this issue, an [@AdaptField annotation on Queue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

So there may actually be 2 or 3 bugs that need to be spun out from this:

# The bytecode transformer is transforming methods/fields that it should not be transforming.
# And one or both of the following:
#* Jenkins core use of the bytecode transformer is not specifying to update StackMapFrame after transformations/rewrites.
#* bytecode transformer is not performing StackMapFrame updates after transformations/rewrites.

In the case where we see this issue, an [@AdaptField annotation on Queue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

So there may actually be 2 or 3 bugs that need to be spun out from this:

# The bytecode transformer is transforming methods/fields that it should not be transforming.
# And one or both of the following:
#* bytecode-compatibility-transformer doesn't support updating of StackMapFrames after manipulation.
#* bytecode-compatibility-transformer does support updating of StackMapFrames after manipulation, but Jenkins core is not using that properly.

It does look as though bytecode-compatibility-transformer has some support for StackMapFrames.

Tom FENNELLY made changes - 2015-06-08 08:09

Description

In the case where we see this issue, an [@AdaptField annotation on Queue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

So there may actually be 2 or 3 bugs that need to be spun out from this:

# The bytecode transformer is transforming methods/fields that it should not be transforming.
# And one or both of the following:
#* bytecode-compatibility-transformer doesn't support updating of StackMapFrames after manipulation.
#* bytecode-compatibility-transformer does support updating of StackMapFrames after manipulation, but Jenkins core is not using that properly.

It does look as though bytecode-compatibility-transformer has some support for StackMapFrames.

In the case where we see this issue, an [@AdaptField annotation on Queue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

So there may actually be 2 or 3 bugs that need to be spun out from this:

# The bytecode transformer is transforming methods/fields that it should not be transforming.
# And one or both of the following:
#* bytecode-compatibility-transformer doesn't properly support updating of StackMapFrames after manipulation.
#* bytecode-compatibility-transformer does support updating of StackMapFrames after manipulation, but Jenkins core is not using that properly.

It does look as though bytecode-compatibility-transformer has some support for StackMapFrames.

James Nord made changes - 2015-06-08 11:44

Assignee

Kohsuke Kawaguchi [ kohsuke ]

James Nord [ teilo ]

Hide

Permalink

James Nord added a comment - 2015-06-08 11:52

There are 2 issues that are seemingly at play here.

1) the affected class does not use any of the Jenkins API and should not have been transformed.
2) the transformer is producing a class that is broken.

Show

James Nord added a comment - 2015-06-08 11:52 There are 2 issues that are seemingly at play here. 1) the affected class does not use any of the Jenkins API and should not have been transformed. 2) the transformer is producing a class that is broken.

Jesse Glick made changes - 2015-06-08 11:54

Link

This issue is related to ~~JENKINS-19383~~ [ ~~JENKINS-19383~~ ]

Hide

Permalink

Tom FENNELLY added a comment - 2015-06-08 11:55

Root cause seems to be the same as with ~~JENKINS-19383~~ i.e. rewriting methods/fields that should not be rewritten.

Show

Tom FENNELLY added a comment - 2015-06-08 11:55 Root cause seems to be the same as with JENKINS-19383 i.e. rewriting methods/fields that should not be rewritten.

Hide

Permalink

James Nord added a comment - 2015-06-08 12:34

unfortunately the binaries for this are not available (unreleased version).

Caused by: java.lang.VerifyError: Expecting a stackmap frame at branch target 20
Exception Details:
  Location:
    org/elasticsearch/common/settings/ImmutableSettings$Builder.get(Ljava/lang/String;)Ljava/lang/String; @15: ifnull
  Reason:
    Expected stackmap frame at this location.
  Bytecode:
    0x0000000: 2ab4 002a 2bb9 003a 0200 c000 354d 2cc6
    0x0000010: 0005 2cb0 2ab4 002a 2bb8 003f b900 3a02
    0x0000020: 00c0 0035 b0

        at org.elasticsearch.common.settings.ImmutableSettings.<clinit>(ImmutableSettings.java:57)
        at com.cloudbees.opscenter.elasticsearch.embedded.EmbeddedNode.start(EmbeddedNode.java:94)

Show

James Nord added a comment - 2015-06-08 12:34 unfortunately the binaries for this are not available (unreleased version). Caused by: java.lang.VerifyError: Expecting a stackmap frame at branch target 20 Exception Details: Location: org/elasticsearch/common/settings/ImmutableSettings$Builder.get(Ljava/lang/String;)Ljava/lang/String; @15: ifnull Reason: Expected stackmap frame at this location. Bytecode: 0x0000000: 2ab4 002a 2bb9 003a 0200 c000 354d 2cc6 0x0000010: 0005 2cb0 2ab4 002a 2bb8 003f b900 3a02 0x0000020: 00c0 0035 b0 at org.elasticsearch.common.settings.ImmutableSettings.<clinit>(ImmutableSettings.java:57) at com.cloudbees.opscenter.elasticsearch.embedded.EmbeddedNode.start(EmbeddedNode.java:94)

Hide

Permalink

James Nord added a comment - 2015-06-08 17:00

https://github.com/jenkinsci/bytecode-compatibility-transformer/pull/2

Show

James Nord added a comment - 2015-06-08 17:00 https://github.com/jenkinsci/bytecode-compatibility-transformer/pull/2

James Nord made changes - 2015-06-08 23:56

Link

This issue is related to ~~JENKINS-28799~~ [ ~~JENKINS-28799~~ ]

James Nord made changes - 2015-06-08 23:58

Summary

bytecode-compatibility-transformer transforming methods/fields it should not be transforming

bytecode-compatibility-transformer produces malformed bytecode

James Nord made changes - 2015-06-08 23:59

Description

In the case where we see this issue, an [@AdaptField annotation on Queue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762] was causing transformations in other classes not intended for transformation (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error.

So there may actually be 2 or 3 bugs that need to be spun out from this:

# The bytecode transformer is transforming methods/fields that it should not be transforming.
# And one or both of the following:
#* bytecode-compatibility-transformer doesn't properly support updating of StackMapFrames after manipulation.
#* bytecode-compatibility-transformer does support updating of StackMapFrames after manipulation, but Jenkins core is not using that properly.

It does look as though bytecode-compatibility-transformer has some support for StackMapFrames.

Alex Java made changes - 2015-07-30 02:59

Link

This issue is related to ~~JENKINS-29692~~ [ ~~JENKINS-29692~~ ]

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-07-30 10:53

Code changed in jenkins
User: James Nord
Path:
src/main/java/org/jenkinsci/bytecode/Transformer.java
http://jenkins-ci.org/commit/bytecode-compatibility-transformer/33cd0196b5f7e1957534ab1d2dae4de78a1bfd5d
Log:
[ISSUE JENKINS-28781] Regernate the stack frames.

We should always re-generate the stack map frames when re-writing methods.

As the asm can not compute frames for code with subroutines we also need
to inline any subroutines.

Show

SCM/JIRA link daemon added a comment - 2015-07-30 10:53 Code changed in jenkins User: James Nord Path: src/main/java/org/jenkinsci/bytecode/Transformer.java http://jenkins-ci.org/commit/bytecode-compatibility-transformer/33cd0196b5f7e1957534ab1d2dae4de78a1bfd5d Log: [ISSUE JENKINS-28781] Regernate the stack frames. We should always re-generate the stack map frames when re-writing methods. As the asm can not compute frames for code with subroutines we also need to inline any subroutines.

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-07-30 10:53

Code changed in jenkins
User: James Nord
Path:
.gitignore
src/main/java/org/jenkinsci/bytecode/Transformer.java
http://jenkins-ci.org/commit/bytecode-compatibility-transformer/cda6033617f92a6acbe571fdb09efafdc4921dab
Log:
Merge pull request #2 from jtnord/~~JENKINS-28781~~-part1

~~JENKINS-28781~~ Fix generated bytecode

Compare: https://github.com/jenkinsci/bytecode-compatibility-transformer/compare/494273053c7c...cda6033617f9

Show

SCM/JIRA link daemon added a comment - 2015-07-30 10:53 Code changed in jenkins User: James Nord Path: .gitignore src/main/java/org/jenkinsci/bytecode/Transformer.java http://jenkins-ci.org/commit/bytecode-compatibility-transformer/cda6033617f92a6acbe571fdb09efafdc4921dab Log: Merge pull request #2 from jtnord/ JENKINS-28781 -part1 JENKINS-28781 Fix generated bytecode Compare: https://github.com/jenkinsci/bytecode-compatibility-transformer/compare/494273053c7c...cda6033617f9

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-10-06 11:09

Code changed in jenkins
User: James Nord
Path:
core/pom.xml
http://jenkins-ci.org/commit/jenkins/80ea8982f35119a19e2d5b36ba3cfefe125d367d
Log:
~~JENKINS-28781~~ update the bct library to 1.6.2.

Pickup the changes in the bytecode-compatibility-transformer for
~~JENKINS-28781~~

Show

SCM/JIRA link daemon added a comment - 2015-10-06 11:09 Code changed in jenkins User: James Nord Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/80ea8982f35119a19e2d5b36ba3cfefe125d367d Log: JENKINS-28781 update the bct library to 1.6.2. Pickup the changes in the bytecode-compatibility-transformer for JENKINS-28781

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-10-06 11:09

Code changed in jenkins
User: James Nord
Path:
core/pom.xml
http://jenkins-ci.org/commit/jenkins/6af3df951fef38e89fe8d01e8b827e8164565171
Log:
Merge pull request #1857 from jtnord/~~JENKINS-28781~~

~~JENKINS-28781~~ update the bct library to 1.6.2.

Compare: https://github.com/jenkinsci/jenkins/compare/a79e2f144a93...6af3df951fef

Show

SCM/JIRA link daemon added a comment - 2015-10-06 11:09 Code changed in jenkins User: James Nord Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/6af3df951fef38e89fe8d01e8b827e8164565171 Log: Merge pull request #1857 from jtnord/ JENKINS-28781 JENKINS-28781 update the bct library to 1.6.2. Compare: https://github.com/jenkinsci/jenkins/compare/a79e2f144a93...6af3df951fef

Hide

Permalink

dogfood added a comment - 2015-10-06 12:27

Integrated in jenkins_main_trunk #4308
~~JENKINS-28781~~ update the bct library to 1.6.2. (Revision 80ea8982f35119a19e2d5b36ba3cfefe125d367d)

Result = SUCCESS
james nord : 80ea8982f35119a19e2d5b36ba3cfefe125d367d
Files :

core/pom.xml

Show

dogfood added a comment - 2015-10-06 12:27 Integrated in jenkins_main_trunk #4308 JENKINS-28781 update the bct library to 1.6.2. (Revision 80ea8982f35119a19e2d5b36ba3cfefe125d367d) Result = SUCCESS james nord : 80ea8982f35119a19e2d5b36ba3cfefe125d367d Files : core/pom.xml

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-10-06 13:11

Code changed in jenkins
User: James Nord
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/7f1ad86d646204fbda45bfcf7a7c044d0d81adce
Log:
Noting ~~JENKINS-28781~~

Show

SCM/JIRA link daemon added a comment - 2015-10-06 13:11 Code changed in jenkins User: James Nord Path: changelog.html http://jenkins-ci.org/commit/jenkins/7f1ad86d646204fbda45bfcf7a7c044d0d81adce Log: Noting JENKINS-28781

James Nord made changes - 2015-10-07 07:53

Link

This issue is related to ~~JENKINS-30820~~ [ ~~JENKINS-30820~~ ]

Hide

Permalink

James Nord added a comment - 2015-10-12 13:04

Fixed in bytecode-compatability-transformer version 1.6.2
integrated into Jenkins 1.633

Show

James Nord added a comment - 2015-10-12 13:04 Fixed in bytecode-compatability-transformer version 1.6.2 integrated into Jenkins 1.633

James Nord made changes - 2015-10-12 13:04

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Jesse Glick made changes - 2016-06-20 15:08

Link

This issue is duplicated by ~~JENKINS-30665~~ [ ~~JENKINS-30665~~ ]

R. Tyler Croy made changes - 2016-07-26 00:01

Workflow

JNJira [ 163639 ]

JNJira + In-Review [ 208856 ]

James Nord made changes - 2020-12-10 13:45

Assignee

James Nord [ teilo ]

People

Assignee:: Unassigned

Reporter:: Tom FENNELLY

Votes:: 2 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 2015-06-06 09:11

Updated:: 2020-12-10 13:45

Resolved:: 2015-10-12 13:04