Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29815

support AuthorizationMatrixProperty.blocksInheritance in folder plugin

      blocksInheritance is available to jobs in a folder, but not to the folder itself. This is important for a 'default open' setup where only certain jobs are excluded/secret/special.

          [JENKINS-29815] support AuthorizationMatrixProperty.blocksInheritance in folder plugin

          Jesse Glick added a comment -

          This functionality needs to be moved to matrix-auth.

          Jesse Glick added a comment - This functionality needs to be moved to matrix-auth .

          Jesse Glick added a comment -

          Has since been moved.

          Jesse Glick added a comment - Has since been moved.

          Code changed in jenkins
          User: Mathias Nyman
          Path:
          src/main/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty.java
          src/main/java/hudson/security/ProjectMatrixAuthorizationStrategy.java
          src/main/resources/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty/config.jelly
          src/main/resources/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty/help-blocksInheritance.html
          src/test/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixPropertyTest.java
          http://jenkins-ci.org/commit/matrix-auth-plugin/63d6897dd0c6db10935c9638639e6da724dea011
          Log:
          JENKINS-29815 Add disabling of permission inheritance for Folders

          This adds the same tick-box to disable inheritance of global permissions
          to Folders as already exists for Projects. Consistency!

          Support for the Folder plugin seems to originally have been done by
          copy-pasting in an only slightly modified version of an ancient copy of
          the AuthorizationMatrixProperty.java file. This commit is as such very
          similar to the patch Kohsuke once applied to the Project's AMP:
          6411fffb41e4e7b217d0e841462ef23a8e62c45a

          Now, these two files are close to identical, and should be refactored
          into one class in my opinion:

          src/main/java/hudson/security/AuthorizationMatrixProperty.java
          src/main/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty.java

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mathias Nyman Path: src/main/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty.java src/main/java/hudson/security/ProjectMatrixAuthorizationStrategy.java src/main/resources/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty/config.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty/help-blocksInheritance.html src/test/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixPropertyTest.java http://jenkins-ci.org/commit/matrix-auth-plugin/63d6897dd0c6db10935c9638639e6da724dea011 Log: JENKINS-29815 Add disabling of permission inheritance for Folders This adds the same tick-box to disable inheritance of global permissions to Folders as already exists for Projects. Consistency! Support for the Folder plugin seems to originally have been done by copy-pasting in an only slightly modified version of an ancient copy of the AuthorizationMatrixProperty.java file. This commit is as such very similar to the patch Kohsuke once applied to the Project's AMP: 6411fffb41e4e7b217d0e841462ef23a8e62c45a Now, these two files are close to identical, and should be refactored into one class in my opinion: src/main/java/hudson/security/AuthorizationMatrixProperty.java src/main/java/com/cloudbees/hudson/plugins/folder/properties/AuthorizationMatrixProperty.java

          Mathias Nyman added a comment -

          Fix is released in matrix-auth-plugin version 1.6.

          Mathias Nyman added a comment - Fix is released in matrix-auth-plugin version 1.6.

            mathias_nyman Mathias Nyman
            cburroughs Chris Burroughs
            Votes:
            4 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: