Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30909

queue.xml only gets persisted on successful shutdown

    XMLWordPrintable

Details

    Description

      So, if Jenkins doesn't shutdown properly, we lose the queueId. This is what we suspect as being the root case of the issue in JENKINS-30899

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-30899 Build History order not sorted properly

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34281 Queue isn't saved on any shutdown

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32820 Queue is not persisted on Safe Restart when Jenkins is installed as Windows Service (clean up is not performed)

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-33926 Jenkins no longer appears to shutdown correctly

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Web Link CloudBees Internal CJP-1708

          Activity

            Ascending order - Click to sort in descending order
            View 7 older comments
            olivergondza Oliver Gondža added a comment -

            Proposing an alternative fix: https://github.com/jenkinsci/jenkins/pull/3244

            olivergondza Oliver Gondža added a comment - Proposing an alternative fix: https://github.com/jenkinsci/jenkins/pull/3244
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/model/Queue.java
            test/pom.xml
            test/src/test/java/hudson/model/QueueRestartTest.java
            test/src/test/java/hudson/model/QueueTest.java
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/a/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/b/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/c/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/d/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/e/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/f/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/g/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/h/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/i/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/j/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/k/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/queue.xml
            http://jenkins-ci.org/commit/jenkins/72a7529a119b2be6b3ff93d63688ee6973404236
            Log:
            [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244)

            • [FIX JENKINS-30909] Make sure queue is persisted reliably
            • Fix tests on Windows
            • Ensure Saver is thread-safe
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/Queue.java test/pom.xml test/src/test/java/hudson/model/QueueRestartTest.java test/src/test/java/hudson/model/QueueTest.java test/src/test/resources/hudson/model/QueueTest/load_queue_xml/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/a/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/b/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/c/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/d/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/e/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/f/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/g/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/h/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/i/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/j/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/k/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/queue.xml http://jenkins-ci.org/commit/jenkins/72a7529a119b2be6b3ff93d63688ee6973404236 Log: [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244) [FIX JENKINS-30909] Make sure queue is persisted reliably Fix tests on Windows Ensure Saver is thread-safe
            oleg_nenashev Oleg Nenashev added a comment -

            Fixed in 2.109. Likely it should be considered as a partial fix.
            olivergondza do you consider it as LTS candidate?

            oleg_nenashev Oleg Nenashev added a comment - Fixed in 2.109. Likely it should be considered as a partial fix. olivergondza do you consider it as LTS candidate?
            olivergondza Oliver Gondža added a comment -

            oleg_nenashev, certainly not for .1, adding the label to be reconsidered later.

            olivergondza Oliver Gondža added a comment - oleg_nenashev , certainly not for .1, adding the label to be reconsidered later.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/model/Queue.java
            test/pom.xml
            test/src/test/java/hudson/model/QueueRestartTest.java
            test/src/test/java/hudson/model/QueueTest.java
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/a/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/b/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/c/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/d/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/e/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/f/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/g/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/h/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/i/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/j/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/k/config.xml
            test/src/test/resources/hudson/model/QueueTest/load_queue_xml/queue.xml
            http://jenkins-ci.org/commit/jenkins/8c975f11c5a366b1693ed2be04e184a714cf2f84
            Log:
            [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244)

            • [FIX JENKINS-30909] Make sure queue is persisted reliably
            • Fix tests on Windows
            • Ensure Saver is thread-safe

            (cherry picked from commit 72a7529a119b2be6b3ff93d63688ee6973404236)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/Queue.java test/pom.xml test/src/test/java/hudson/model/QueueRestartTest.java test/src/test/java/hudson/model/QueueTest.java test/src/test/resources/hudson/model/QueueTest/load_queue_xml/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/a/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/b/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/c/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/d/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/e/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/f/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/g/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/h/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/i/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/j/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/jobs/k/config.xml test/src/test/resources/hudson/model/QueueTest/load_queue_xml/queue.xml http://jenkins-ci.org/commit/jenkins/8c975f11c5a366b1693ed2be04e184a714cf2f84 Log: [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244) [FIX JENKINS-30909] Make sure queue is persisted reliably Fix tests on Windows Ensure Saver is thread-safe (cherry picked from commit 72a7529a119b2be6b3ff93d63688ee6973404236)

            People

              olivergondza Oliver Gondža
              tfennelly Tom FENNELLY
              Votes:
              4 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: