Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/model/Queue.java
http://jenkins-ci.org/commit/jenkins/cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2
Log:
[FIXED JENKINS-31649] Check should be against AccessControlled and Permission.READ

• The previous check was to narrow.
• We now check on AccessControlled (which is implemented by Item)
• We now also check on Permission.READ (which is the generic read permission)

This should allow subtasks who's task may not be an Item to at least implement AccessControlled to alow visibility.

There remains an open question as to whether tasks that are not AccessControlled should ever be visible in the UI

Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/model/Queue.java
http://jenkins-ci.org/commit/jenkins/46ef3a5776b9a60a1e5d364c29afda01fa09faed
Log:
Merge pull request #1919 from stephenc/jenkins-31649

[FIXED JENKINS-31649] Check should be against AccessControlled not Item

Compare: https://github.com/jenkinsci/jenkins/compare/23276180209b...46ef3a5776b9

Reproducible in 1.625.2 even with no security: create a Workflow job

node('whatever') {}

and build. You should see an entry in the queue widget, but you do not.

PR 1919 would not fix that. However I could make PlaceholderTask be AccessControlled, in which case a backport of this fix plus a plugin update would correct the regression.

Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/queue/AbstractQueueTask.java
http://jenkins-ci.org/commit/jenkins/e930da45ff4c48dfcaadc57e01485051d2a04b1d
Log:
JENKINS-31649 Tidy-up javadoc comments after merge of JENKINS-31649

Code changed in jenkins
User: Jesse Glick
Path:
CHANGES.md
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ExecutorStepTest.java
support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
http://jenkins-ci.org/commit/workflow-plugin/b9376a9f906dbb142acfe605be9c8358bcd66c3d
Log:
JENKINS-31649 When supported by Jenkins core, display queue items to authorized users.

Code changed in jenkins
User: Jesse Glick
Path:
CHANGES.md
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/ExecutorStepTest.java
support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
http://jenkins-ci.org/commit/workflow-plugin/8dd67dd83e0ff60cdd284ae14e6316006c0eff34
Log:
Merge pull request #258 from jglick/PlaceholderTask-visibility-JENKINS-31649

JENKINS-31649 Integrate with post-SECURITY-186 queue item display policy

Compare: https://github.com/jenkinsci/workflow-plugin/compare/3d60b260ee0c...8dd67dd83e0f

Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/model/Queue.java
http://jenkins-ci.org/commit/jenkins/b51653d2bfa1a8b4e854bb0991202879e7228da8
Log:
[FIXED JENKINS-31649] Check should be against AccessControlled and Permission.READ

• The previous check was to narrow.
• We now check on AccessControlled (which is implemented by Item)
• We now also check on Permission.READ (which is the generic read permission)

This should allow subtasks who's task may not be an Item to at least implement AccessControlled to alow visibility.

There remains an open question as to whether tasks that are not AccessControlled should ever be visible in the UI

(cherry picked from commit cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2)

Integrated in jenkins_main_trunk #4373
[FIXED JENKINS-31649] Check should be against AccessControlled and Permission.READ (Revision cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2)
JENKINS-31649 Tidy-up javadoc comments after merge of JENKINS-31649 (Revision e930da45ff4c48dfcaadc57e01485051d2a04b1d)
[FIXED JENKINS-31649] Check should be against AccessControlled and Permission.READ (Revision b51653d2bfa1a8b4e854bb0991202879e7228da8)

Result = SUCCESS
stephen connolly : cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2
Files :

• core/src/main/java/hudson/model/Queue.java

stephen connolly : e930da45ff4c48dfcaadc57e01485051d2a04b1d
Files :

• core/src/main/java/hudson/model/Queue.java
• core/src/main/java/hudson/model/queue/AbstractQueueTask.java

ogondza : b51653d2bfa1a8b4e854bb0991202879e7228da8
Files :

• core/src/main/java/hudson/model/Queue.java

Integrated in jenkins_2.0 #5
[FIXED JENKINS-31649] Check should be against AccessControlled and (Revision cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2)
JENKINS-31649 Tidy-up javadoc comments after merge of JENKINS-31649 (Revision e930da45ff4c48dfcaadc57e01485051d2a04b1d)
[FIXED JENKINS-31649] Check should be against AccessControlled and (Revision b51653d2bfa1a8b4e854bb0991202879e7228da8)

Result = SUCCESS
stephen connolly : cf1fdf98e435b4c7df54f1a8e958d185f1a0f3d2
Files :

• core/src/main/java/hudson/model/Queue.java

stephen connolly : e930da45ff4c48dfcaadc57e01485051d2a04b1d
Files :

• core/src/main/java/hudson/model/Queue.java
• core/src/main/java/hudson/model/queue/AbstractQueueTask.java

ogondza : b51653d2bfa1a8b4e854bb0991202879e7228da8
Files :

• core/src/main/java/hudson/model/Queue.java