Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31717

docker-build-publish plugin no longer works with spaces in the workspace path

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Between 1.0.1 and 1.1, this plugin has broken builds where workspaces have spaces in the names, as you can see below.

      In 1.1:

      [Build Intervent.io] $ docker build -t tutum.co/matthewbaggett/interventio /var/lib/jenkins/workspace/Build Intervent.io
      docker: "build" requires 1 argument.
      See 'docker build --help'.
      
      Usage: docker build [OPTIONS] PATH | URL | -
      
      Build a new image from the source code at PATH
      Build step 'Docker Build and Publish' marked build as failure
      

      In 1.0.1:

      [Build Intervent.io] $ docker build -t tutum.co/matthewbaggett/interventio .
      

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment -

            Matthew Baggett so a path with no spaces is ok?

            this does seem like a regression.

            Show
            michaelneale Michael Neale added a comment - Matthew Baggett so a path with no spaces is ok? this does seem like a regression.
            Show
            michaelneale Michael Neale added a comment - Carlos Sanchez looks like this was caused by this merge: https://github.com/jenkinsci/docker-build-publish-plugin/commit/73c8a2b0f2838df38b46e9b50f47b0133ffde35c#diff-a7c45f7e2ba80619b5aad549aadc5ef3R322 ie: https://github.com/jenkinsci/docker-build-publish-plugin/blob/master/src/main/java/com/cloudbees/dockerpublish/DockerBuilder.java#L323 which won't work if the workspace has space in its name (probably common).
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Michael Neale
            Path:
            src/main/java/com/cloudbees/dockerpublish/DockerBuilder.java
            http://jenkins-ci.org/commit/docker-build-publish-plugin/fae73184f1e707868a2e8958ed11c62b258a8419
            Log:
            fix for JENKINS-31717 allow spaces in workspace

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Neale Path: src/main/java/com/cloudbees/dockerpublish/DockerBuilder.java http://jenkins-ci.org/commit/docker-build-publish-plugin/fae73184f1e707868a2e8958ed11c62b258a8419 Log: fix for JENKINS-31717 allow spaces in workspace
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Carlos Sanchez
            Path:
            src/main/java/com/cloudbees/dockerpublish/DockerBuilder.java
            http://jenkins-ci.org/commit/docker-build-publish-plugin/4a78fa202a0906586b6e1132aacfeac652236fb2
            Log:
            Merge pull request #34 from jenkinsci/topic/workspaces-with-spaces

            fix for JENKINS-31717 allow spaces in workspace

            Compare: https://github.com/jenkinsci/docker-build-publish-plugin/compare/c3d13c11b33c...4a78fa202a09

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: src/main/java/com/cloudbees/dockerpublish/DockerBuilder.java http://jenkins-ci.org/commit/docker-build-publish-plugin/4a78fa202a0906586b6e1132aacfeac652236fb2 Log: Merge pull request #34 from jenkinsci/topic/workspaces-with-spaces fix for JENKINS-31717 allow spaces in workspace Compare: https://github.com/jenkinsci/docker-build-publish-plugin/compare/c3d13c11b33c...4a78fa202a09
            Show
            csanchez Carlos Sanchez added a comment - Fixed in https://github.com/jenkinsci/docker-build-publish-plugin/pull/34

              People

              Assignee:
              csanchez Carlos Sanchez
              Reporter:
              matthewbaggett Matthew Baggett
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: