Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31748

Check-in comment text truncated from recent changes detail pages

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • p4-plugin
    • Jenkins ver. 1.625.2
      P4 plugin 1.3.3
      OS: RHEL 6.4
      Java: 1.8.0_60

    Description

      We are seeing check-in comments are truncated to 31 characters on the main "Recent Changes" and build number specific "summary of changes" detail pages.

      It seems to be happening most often when there is more than one line of text, but also it is sometimes truncating single line check-in comments.

      Attachments

        Issue Links

          Activity

            Code changed in jenkins
            User: Paul Allen
            Path:
            src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java
            http://jenkins-ci.org/commit/p4-plugin/571f235c1da25adaa1c2904324df5e56037c331a
            Log:
            Fetch full change description.

            The 'p4 changes' optimisation only fetched the first 32 characters.
            Added the '-l' flag to fetch the full description.

            JENKINS-31748

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java http://jenkins-ci.org/commit/p4-plugin/571f235c1da25adaa1c2904324df5e56037c331a Log: Fetch full change description. The 'p4 changes' optimisation only fetched the first 32 characters. Added the '-l' flag to fetch the full description. JENKINS-31748
            p4paul Paul Allen added a comment -

            Hi Andrew,
            I have submitted the fix. Not sure when the next release will occur, but you can try out the build here:
            https://jenkins.ci.cloudbees.com/job/plugins/job/p4-plugin/270/org.jenkins-ci.plugins$p4/
            Paul

            p4paul Paul Allen added a comment - Hi Andrew, I have submitted the fix. Not sure when the next release will occur, but you can try out the build here: https://jenkins.ci.cloudbees.com/job/plugins/job/p4-plugin/270/org.jenkins-ci.plugins$p4/ Paul
            philmcardlecg Phil McArdle added a comment -

            The above build worked for me

            Phil

            philmcardlecg Phil McArdle added a comment - The above build worked for me Phil
            p4paul Paul Allen added a comment -

            Thank you for confirming the fix.

            p4paul Paul Allen added a comment - Thank you for confirming the fix.
            barnish Andrew Barnish added a comment - - edited

            This is working in the 1.3.4 release of p4-plugin. Please close.

            barnish Andrew Barnish added a comment - - edited This is working in the 1.3.4 release of p4-plugin. Please close.

            People

              p4paul Paul Allen
              barnish Andrew Barnish
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: