Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33318

GitHub Enterprise Server validation does not work when private mode is enabled

      The method checkApiUrlValidity() does not work fine when a GitHub Enterprise instance is configured in private mode.

      When I've added this method in GitHub API forget to check with this configuration:

      public void checkApiUrlValidity() throws IOException {
          retrieve().to("/", GHApiInfo.class).check(apiUrl);
      }
      

      Probably, we need to do changes in this plugin (to handle the error) and in GitHub API.

          [JENKINS-33318] GitHub Enterprise Server validation does not work when private mode is enabled

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/e32e6946dde44fe66f6b14fc54e764c88ddb3489
          Log:
          JENKINS-33318 @svanoort's comment was addressed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java http://jenkins-ci.org/commit/github-branch-source-plugin/e32e6946dde44fe66f6b14fc54e764c88ddb3489 Log: JENKINS-33318 @svanoort's comment was addressed

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/6f511f42b44a8b6da99c5e17b32fea2662990424
          Log:
          JENKINS-33318 @svanoort's comment was addressed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java http://jenkins-ci.org/commit/github-branch-source-plugin/6f511f42b44a8b6da99c5e17b32fea2662990424 Log: JENKINS-33318 @svanoort's comment was addressed

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/c990cdf59531616b7dd343b02eb6aa9338cc44ee
          Log:
          JENKINS-33318 Reverted a modified line

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/c990cdf59531616b7dd343b02eb6aa9338cc44ee Log: JENKINS-33318 Reverted a modified line

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/2fab60db66f3d6335825172803e5d4dbd76c6542
          Log:
          JENKINS-33318 @svanoort's comment was addressed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java http://jenkins-ci.org/commit/github-branch-source-plugin/2fab60db66f3d6335825172803e5d4dbd76c6542 Log: JENKINS-33318 @svanoort's comment was addressed

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/af04b025e3fd18d4f152109f0d64cf30a781328d
          Log:
          Merge pull request #27 from recena/JENKINS-33318

          JENKINS-33318 GHE server validation with private mode enabled

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/844f9c0d3dfc...af04b025e3fd

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html http://jenkins-ci.org/commit/github-branch-source-plugin/af04b025e3fd18d4f152109f0d64cf30a781328d Log: Merge pull request #27 from recena/ JENKINS-33318 JENKINS-33318 GHE server validation with private mode enabled Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/844f9c0d3dfc...af04b025e3fd

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/58db4cc1545ad5cf4e968f3513d218b5ce22e0f4
          Log:
          Revert "JENKINS-33318 GHE server validation with private mode enabled"

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html http://jenkins-ci.org/commit/github-branch-source-plugin/58db4cc1545ad5cf4e968f3513d218b5ce22e0f4 Log: Revert " JENKINS-33318 GHE server validation with private mode enabled"

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/8a607fb0e7c8e374e567d177ed84e2b432c49679
          Log:
          Merge pull request #45 from jenkinsci/revert-27-JENKINS-33318

          Revert "JENKINS-33318 GHE server validation with private mode enabled"

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/af04b025e3fd...8a607fb0e7c8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html http://jenkins-ci.org/commit/github-branch-source-plugin/8a607fb0e7c8e374e567d177ed84e2b432c49679 Log: Merge pull request #45 from jenkinsci/revert-27- JENKINS-33318 Revert " JENKINS-33318 GHE server validation with private mode enabled" Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/af04b025e3fd...8a607fb0e7c8

          Code changed in jenkins
          User: recena
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/42655c54e7eee809208b0845404d7b3fb3157a16
          Log:
          JENKINS-33318 GHE server validation with private mode enabled

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html http://jenkins-ci.org/commit/github-branch-source-plugin/42655c54e7eee809208b0845404d7b3fb3157a16 Log: JENKINS-33318 GHE server validation with private mode enabled

          Code changed in jenkins
          User: recena
          Path:
          pom.xml
          http://jenkins-ci.org/commit/github-branch-source-plugin/2a812c2eea6e4d989c116180bb15cc1bbc8c72d7
          Log:
          JENKINS-33318 Upgraded github-api dependency

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: pom.xml http://jenkins-ci.org/commit/github-branch-source-plugin/2a812c2eea6e4d989c116180bb15cc1bbc8c72d7 Log: JENKINS-33318 Upgraded github-api dependency

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/80a151959a75a0bd7665d39f9c0696ef6a1c988c
          Log:
          Merge pull request #46 from recena/JENKINS-33318

          JENKINS-33318 GHE server validation with private mode enabled

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/8a607fb0e7c8...80a151959a75

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java src/main/resources/org/jenkinsci/plugins/github_branch_source/Endpoint/help-apiUri.html http://jenkins-ci.org/commit/github-branch-source-plugin/80a151959a75a0bd7665d39f9c0696ef6a1c988c Log: Merge pull request #46 from recena/ JENKINS-33318 JENKINS-33318 GHE server validation with private mode enabled Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/8a607fb0e7c8...80a151959a75

            recena Manuel Recena Soto
            recena Manuel Recena Soto
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: