If you have some tool constantly pinging jobs/.../build?token=... but the job is stuck in the queue for a long time, you will get a CauseAction with a potentially unbounded number of causes, all identical RemoteCause instances. In a system with tens of thousands of build records loaded, there can be millions of such causes. This is a waste of heap space (and disk space, disk I/O time to load).

          [JENKINS-33467] CauseAction.causes can become huge

          Code changed in jenkins
          User: Timo Mihaljov
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/d56ff03bf4838c541e68f4cfc06f59ba78d12317
          Log:
          JENKINS-33591 Don't modify CauseAction's causes

          The cause list is immutable as described in the comments of
          JENKINS-33467.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Timo Mihaljov Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java http://jenkins-ci.org/commit/build-pipeline-plugin/d56ff03bf4838c541e68f4cfc06f59ba78d12317 Log: JENKINS-33591 Don't modify CauseAction's causes The cause list is immutable as described in the comments of JENKINS-33467 .

          I prefer not to backport this into 1.651.1 since fix in one of the affected plugins is not released yet. Plus, This is more of an improvement than a bug fix.

          Oliver Gondža added a comment - I prefer not to backport this into 1.651.1 since fix in one of the affected plugins is not released yet. Plus, This is more of an improvement than a bug fix.

          Code changed in jenkins
          User: Robert Sandell
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/03d057f88f08e4b3ca9e14eebd48df043e27067f
          Log:
          Don't crash because JENKINS-33467 has changed expected behaviour

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/03d057f88f08e4b3ca9e14eebd48df043e27067f Log: Don't crash because JENKINS-33467 has changed expected behaviour

          Jesse Glick added a comment -

          The Delivery Pipeline plugin bug seems to have been fixed & released already. Unclear to me what https://github.com/jenkinsci/gerrit-trigger-plugin/pull/278 is about—it is not linked to a distinct issue which would explain the symptom.

          Jesse Glick added a comment - The Delivery Pipeline plugin bug seems to have been fixed & released already. Unclear to me what https://github.com/jenkinsci/gerrit-trigger-plugin/pull/278 is about—it is not linked to a distinct issue which would explain the symptom.

          Jesse Glick added a comment -

          But yeah if you consider this a performance improvement rather than a bug fix per se then you could just remove lts-candidate.

          Jesse Glick added a comment - But yeah if you consider this a performance improvement rather than a bug fix per se then you could just remove lts-candidate .

          Code changed in jenkins
          User: Robert Sandell
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/f1a6a398ba1cf1f1f1ce1fb48e84a437ec3fb3bb
          Log:
          Merge pull request #278 from jenkinsci/JENKINS-33467

          Don't crash because JENKINS-33467 has changed expected behaviour

          Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b7ab5892c183...f1a6a398ba1c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/f1a6a398ba1cf1f1f1ce1fb48e84a437ec3fb3bb Log: Merge pull request #278 from jenkinsci/ JENKINS-33467 Don't crash because JENKINS-33467 has changed expected behaviour Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b7ab5892c183...f1a6a398ba1c

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/CauseAction.java
          test/src/test/java/hudson/model/QueueTest.java
          http://jenkins-ci.org/commit/jenkins/916e759f576fd9aec7eb563f71f6541ceb37f641
          Log:
          [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction.
          (cherry picked from commit 6ae54add5dd3f171cf7cca820ca2e5443ae34b14)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/CauseAction.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/916e759f576fd9aec7eb563f71f6541ceb37f641 Log: [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction. (cherry picked from commit 6ae54add5dd3f171cf7cca820ca2e5443ae34b14)

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/CauseAction.java
          http://jenkins-ci.org/commit/jenkins/63886be9f75c6f538b9401d9cb445b701b1f017c
          Log:
          JENKINS-33467 Clarifying that CauseAction.getCauses is immutable and you should construct the action with the causes you want.
          (cherry picked from commit 4adee7597aad7a338db8d3eb320575ae618a8c81)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/CauseAction.java http://jenkins-ci.org/commit/jenkins/63886be9f75c6f538b9401d9cb445b701b1f017c Log: JENKINS-33467 Clarifying that CauseAction.getCauses is immutable and you should construct the action with the causes you want. (cherry picked from commit 4adee7597aad7a338db8d3eb320575ae618a8c81)

          Code changed in jenkins
          User: Dan Alvizu
          Path:
          src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
          http://jenkins-ci.org/commit/build-pipeline-plugin/27e234d2f1b8c86e28465d6a2d8ace5db9c7d778
          Log:
          Fixed JENKINS-33935

          Jenkins core made CauseAction.getCauses an unmodifiable collection
          (JENKINS-33467) - so we need to make a copy.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java http://jenkins-ci.org/commit/build-pipeline-plugin/27e234d2f1b8c86e28465d6a2d8ace5db9c7d778 Log: Fixed JENKINS-33935 Jenkins core made CauseAction.getCauses an unmodifiable collection ( JENKINS-33467 ) - so we need to make a copy.

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/model/CauseAction.java
          http://jenkins-ci.org/commit/jenkins/d53cab3ef68b62a4a6dbb247012577c338dfc133
          Log:
          JENKINS-33467 Adjust reported Jenkins version number for LTS

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/CauseAction.java http://jenkins-ci.org/commit/jenkins/d53cab3ef68b62a4a6dbb247012577c338dfc133 Log: JENKINS-33467 Adjust reported Jenkins version number for LTS

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: