Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33530

Pull Requests "submitted from origin repository, skipping" not clear why this is skipping

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The github-branch-source-plugin says that it should build branches and PR's, and from digging through commit history, I see that it is intended for private repos only, and it will not work for remote repos. However I have a private repo, and my PR's are all from origin, and it scans my pull requests, it says "submitted from origin repository, skipping".

      I've looked through https://github.com/jenkinsci/workflow-plugin/blob/master/TUTORIAL.md#creating-multibranch-projects , and I've looked at the PR that put this check in place, https://github.com/jenkinsci/github-branch-source-plugin/pull/14 , but no where does it try to explain why we are skipping because it was "submitted from origin repository", isn't that the ideal PR to build? Because we know they have access to that repo since it is from origin?

      If there is a legit reason for this, then this message should be clarified better.

      Link to the code that specifies that it should skip a pull request in this situation, https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L290-L292 . Why would we want to ignore PR's from the origin repo?

        Attachments

          Issue Links

            Activity

            Hide
            jkoenig Jeff Koenig added a comment -

            I have removed this check, build the plugin and installed it on my jenkins server and I'm not using it successfully. If you think this change is ok, I'm happy to open a pull request for it.

            Show
            jkoenig Jeff Koenig added a comment - I have removed this check, build the plugin and installed it on my jenkins server and I'm not using it successfully. If you think this change is ok, I'm happy to open a pull request for it.
            Hide
            jamesmaidment James Maidment added a comment - - edited

            +1 Would love this feature to be enabled.

            Show
            jamesmaidment James Maidment added a comment - - edited +1 Would love this feature to be enabled.
            Show
            jkoenig Jeff Koenig added a comment - PR Created: https://github.com/jenkinsci/github-branch-source-plugin/pull/36
            Hide
            michaelneale Michael Neale added a comment -
            Show
            michaelneale Michael Neale added a comment - Is this the same thing as https://issues.jenkins-ci.org/browse/JENKINS-33161 ?

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jkoenig Jeff Koenig
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: