Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33559

Job configuration "search" box doesn't properly clear highlights

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • core
    • 2.0-alpha3

      (setting aside my view that this search box is superfluous)

      When you search for something on the page, e.g. "CVS", the view will scroll to the element and highlight the search query on the page.

      When the search field is cleared, the highlight remains, see attached screenshot.

        1. job-configuration-search-doesnt-clear.png
          job-configuration-search-doesnt-clear.png
          57 kB

          [JENKINS-33559] Job configuration "search" box doesn't properly clear highlights

          Daniel Beck added a comment -

          The box will get removed soon, it's kind of useless for scroll-spying anyway.

          Daniel Beck added a comment - The box will get removed soon, it's kind of useless for scroll-spying anyway.

          Daniel Beck added a comment -

          Asking tfennelly for confirmation on the above.

          Daniel Beck added a comment - Asking tfennelly for confirmation on the above.

          Tom FENNELLY added a comment -

          Yes, that is a bug and is fixed in https://github.com/jenkinsci/jenkins/pull/2121.

          I also agree that the find feature is not so useful with scrollspy since the user can use cmd+f anyway. Maybe we should juts remove it for scrollspy.

          Tom FENNELLY added a comment - Yes, that is a bug and is fixed in https://github.com/jenkinsci/jenkins/pull/2121 . I also agree that the find feature is not so useful with scrollspy since the user can use cmd+f anyway. Maybe we should juts remove it for scrollspy.

          Antonio Muñiz added a comment -

          Is this bug related to JENKINS-33620 (or can they be fixed at the same time?)

          Antonio Muñiz added a comment - Is this bug related to JENKINS-33620 (or can they be fixed at the same time?)

          Antonio Muñiz added a comment -

          Well, if the search box is removed then both issue would become out-dated.

          Antonio Muñiz added a comment - Well, if the search box is removed then both issue would become out-dated.

          Kohsuke Kawaguchi added a comment -

          Sounds like the consensus is that this issue should be closed because of the change made since then.

          Kohsuke Kawaguchi added a comment - Sounds like the consensus is that this issue should be closed because of the change made since then.

          Kohsuke Kawaguchi added a comment -

          Based on the comments that this feature is soon to be removed.

          Kohsuke Kawaguchi added a comment - Based on the comments that this feature is soon to be removed.

          Spike Washburn added a comment -

          Gus is planning to remove this in PR-2117

          Spike Washburn added a comment - Gus is planning to remove this in PR-2117

          Tom FENNELLY added a comment -

          The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.

          Tom FENNELLY added a comment - The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.

          Tom FENNELLY added a comment -

          I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages.

          It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.

          Tom FENNELLY added a comment - I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages. It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.

            tfennelly Tom FENNELLY
            rtyler R. Tyler Croy
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: