Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33559

Job configuration "search" box doesn't properly clear highlights

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      (setting aside my view that this search box is superfluous)

      When you search for something on the page, e.g. "CVS", the view will scroll to the element and highlight the search query on the page.

      When the search field is cleared, the highlight remains, see attached screenshot.

        Attachments

          Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-33620 Clearing the search box fully hides the configuration page

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            kohsuke Kohsuke Kawaguchi added a comment -

            Sounds like the consensus is that this issue should be closed because of the change made since then.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Sounds like the consensus is that this issue should be closed because of the change made since then.
            Hide
            Permalink
            kohsuke Kohsuke Kawaguchi added a comment -

            Based on the comments that this feature is soon to be removed.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Based on the comments that this feature is soon to be removed.
            Hide
            Permalink
            swashbuck1r Spike Washburn added a comment -

            Gus is planning to remove this in PR-2117

            Show
            swashbuck1r Spike Washburn added a comment - Gus is planning to remove this in PR-2117
            Hide
            Permalink
            tfennelly Tom FENNELLY added a comment -

            The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.

            Show
            tfennelly Tom FENNELLY added a comment - The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.
            Hide
            Permalink
            tfennelly Tom FENNELLY added a comment -

            I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages.

            It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.

            Show
            tfennelly Tom FENNELLY added a comment - I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages. It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.

              People

              Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              rtyler R. Tyler Croy
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: