Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33930

new tabbed job config page broken accessibility

XMLWordPrintable

      you can no longer use the keyboard to navigate on the restyled "FreeStyle" job configuration page.

      There is no way to change the tabs which would confuse a user (they are not tabs - but look like tabs? - when an item gets focus via a tab key the "tab" thing should change highlight as it does if you just scroll
      The tabbing order of the items and help is completely out of whack.
      The red X on a build step never seems to receive focus

        1. Screenshot 2016-05-30 10.59.05.png
          Screenshot 2016-05-30 10.59.05.png
          18 kB

          [JENKINS-33930] new tabbed job config page broken accessibility

          James Nord added a comment - - edited

          If the RedX is not visually highlighted in 2.0 how do you know it is selected - how do you know you have navigated to it?

          James Nord added a comment - - edited If the RedX is not visually highlighted in 2.0 how do you know it is selected - how do you know you have navigated to it?

          Daniel Beck added a comment -

          gusreiber Is there a quick and easy way to add keyboard focus highlighting to the X button?

          Daniel Beck added a comment - gusreiber Is there a quick and easy way to add keyboard focus highlighting to the X button?

          gus reiber added a comment -

          taking a look.

          gus reiber added a comment - taking a look.

          gus reiber added a comment -

          ....waiting for gitHub.

          gus reiber added a comment - ....waiting for gitHub.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: gusreiber
          Path:
          war/src/main/js/widgets/config/tabbar.less
          http://jenkins-ci.org/commit/jenkins/99e482b2a94102c6c2b3445c2fa1514f242fede5
          Log:
          JENKINS-33930 focus color for delete

          style only.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: gusreiber Path: war/src/main/js/widgets/config/tabbar.less http://jenkins-ci.org/commit/jenkins/99e482b2a94102c6c2b3445c2fa1514f242fede5 Log: JENKINS-33930 focus color for delete style only.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          war/src/main/js/widgets/config/tabbar.less
          http://jenkins-ci.org/commit/jenkins/c403e88f44034919de07ddb3d6b419c5016f77d7
          Log:
          Merge pull request #2227 from jenkinsci/FIX-JENKINS-33930]

          JENKINS-33930 focus color for delete

          Compare: https://github.com/jenkinsci/jenkins/compare/e6df9f55bb6b...c403e88f4403

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: war/src/main/js/widgets/config/tabbar.less http://jenkins-ci.org/commit/jenkins/c403e88f44034919de07ddb3d6b419c5016f77d7 Log: Merge pull request #2227 from jenkinsci/FIX- JENKINS-33930 ] JENKINS-33930 focus color for delete Compare: https://github.com/jenkinsci/jenkins/compare/e6df9f55bb6b...c403e88f4403

          Arnaud Héritier added a comment - - edited

          Is it a known issue the rendering of the delete button in config panels ?

          I didn't find it reported but I saw it for a long time

          Arnaud Héritier added a comment - - edited Is it a known issue the rendering of the delete button in config panels ? I didn't find it reported but I saw it for a long time

          Arnaud Héritier added a comment -

          Ok I just found JENKINS-35178 and PR https://github.com/jenkinsci/jenkins/pull/2378 by recena

          Arnaud Héritier added a comment - Ok I just found JENKINS-35178 and PR https://github.com/jenkinsci/jenkins/pull/2378 by recena

          Manuel Recena Soto added a comment -

          teilo, Could you confirm whether it was fixed on JENKINS-35178?

          Manuel Recena Soto added a comment - teilo , Could you confirm whether it was fixed on JENKINS-35178 ?

          James Nord added a comment -

          Was partially fixed by https://github.com/jenkinsci/jenkins/pull/2227 (delete not showing focus)
          Tab seems order is fixed
          Tab selecting UX issue(s) remain

          • Can not change them with tab
          • Highlighted tab is not for the section you are editing/has focus (but is the same now if you use the mouse - the tab highlight matches what is at the top of the screen)

          James Nord added a comment - Was partially fixed by https://github.com/jenkinsci/jenkins/pull/2227 (delete not showing focus) Tab seems order is fixed Tab selecting UX issue(s) remain Can not change them with tab Highlighted tab is not for the section you are editing/has focus (but is the same now if you use the mouse - the tab highlight matches what is at the top of the screen)

            recena Manuel Recena Soto
            teilo James Nord
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: