• Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline

      So that the properties step can be used to define, for example, a daily build schedule for some or all branch projects.

          [JENKINS-34005] Make WorkflowJob.triggers into a JobProperty

          Andrew Bayer added a comment -

          Would the JobProperty contain a DescribableList of TriggerDescriptor/Trigger?

          Andrew Bayer added a comment - Would the JobProperty contain a DescribableList of TriggerDescriptor / Trigger ?

          Andrew Bayer added a comment -

          I ask because it seems a little silly to try to create some way of translating each Trigger into some non-Trigger format we can store in the JobProperty...

          Andrew Bayer added a comment - I ask because it seems a little silly to try to create some way of translating each Trigger into some non- Trigger format we can store in the JobProperty ...

          Andrew Bayer added a comment -

          Also, turns out JobProperty already implements ReconfigurableDescribable so I am not clear on what to do at the lower level now. Hrm.

          Andrew Bayer added a comment - Also, turns out JobProperty already implements ReconfigurableDescribable so I am not clear on what to do at the lower level now. Hrm.

          Jesse Glick added a comment -

          Use List<Trigger>.

          Jesse Glick added a comment - Use List<Trigger> .

          Andrew Bayer added a comment -

          Got my head straight on this and am moving forward. =)

          Andrew Bayer added a comment - Got my head straight on this and am moving forward. =)

          Andrew Bayer added a comment -

          Andrew Bayer added a comment - Initial PR work up at https://github.com/jenkinsci/workflow-job-plugin/pull/9

          Andrew Bayer added a comment -

          PR is basically functional now with decent testing, I think. Need to add a properties step test in workflow-multibranch still, and will need review, but I think we're most of the way there.

          Andrew Bayer added a comment - PR is basically functional now with decent testing, I think. Need to add a properties step test in workflow-multibranch still, and will need review, but I think we're most of the way there.

          Andrew Bayer added a comment -

          Multibranch test-related PR up as well. Snapshot deployed to support that.

          Andrew Bayer added a comment - Multibranch test-related PR up as well. Snapshot deployed to support that.

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/25b46d278c43817556fe8492ad811418d51fa66e
          Log:
          JENKINS-34005 Add test for PipelineTriggersJobProperty.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/25b46d278c43817556fe8492ad811418d51fa66e Log: JENKINS-34005 Add test for PipelineTriggersJobProperty.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/96993738c5fcead1076e613d5f2b5a34e6f3d466
          Log:
          Merge pull request #20 from abayer/jenkins-34005

          JENKINS-34005 - update tests for PipelineTriggersJobProperty

          Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/66ef6fa432d6...96993738c5fc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/96993738c5fcead1076e613d5f2b5a34e6f3d466 Log: Merge pull request #20 from abayer/jenkins-34005 JENKINS-34005 - update tests for PipelineTriggersJobProperty Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/66ef6fa432d6...96993738c5fc

            abayer Andrew Bayer
            jglick Jesse Glick
            Votes:
            10 Vote for this issue
            Watchers:
            17 Start watching this issue

              Created:
              Updated:
              Resolved: