-
Bug
-
Resolution: Fixed
-
Critical
-
None
If I create a PR in github, the build automatically gets created.
However, if it fails, the next branch indexing log (which happened just after) does this:
Getting remote pull requests...
Checking pull request #PR-4
Not mergeable, skipping
This removes the build entirely - so one cannot find out why it failed.
Incidentally, the "Not mergeable" isn't correct - it is mergeable, it's just Jenkins has reported a check-failure against it.
- is related to
-
-
- Resolved
-
-
JENKINS-33161 Allow merge commits to be built from origin PRs
-
- Resolved
-
- links to
[JENKINS-34120] Do not suppress unmergeable PRs
I thought this was already filed, but cannot find it now. Anyway, the suggested resolution is simple: do not check mergeability during branch indexing, so always create the branch project; when performing the build, if there is a merge failure, fail the build.
magnayn
added a comment - When I looked in github, as far as it was concerned it was still mergeable; the only check that had failed (and the only one we use) was the Jenkins build.
magnayn
added a comment - When I looked in github, as far as it was concerned it was still mergeable; the only check that had failed (and the only one we use) was the Jenkins build. By the way, I don't think this is a bug but a design decision that may be changed.
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
http://jenkins-ci.org/commit/github-branch-source-plugin/df2fc42f25cd4f0f220c00b4a75d2e0c25633408
Log:
JENKINS-34120 Mergeability is not a condition to add a new job for a PR
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
http://jenkins-ci.org/commit/github-branch-source-plugin/970cf7747f4fac211b0cf36b8f8be4c377f03c9e
Log:
JENKINS-34120 Typo
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
http://jenkins-ci.org/commit/github-branch-source-plugin/fd767d92e00cae2784ebc74a723eff017045b658
Log:
JENKINS-34120 More legible
Code changed in jenkins
User: Manuel Recena
Path:
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
http://jenkins-ci.org/commit/github-branch-source-plugin/c6ac8156e5f5ba3e1e7277ba1d059ff515fe42e2
Log:
Merge pull request #51 from recena/JENKINS-34120
JENKINS-34120 Mergeability is not a condition to add a new job linked to a PR
Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/4970dbc528f0...c6ac8156e5f5
Dubious. The stated error message indicates that GitHub considers the PR to not be mergeable without conflict. Has nothing to do with Jenkins build results.