Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34676

Duplicate include of pluginSetupWizard.js

XMLWordPrintable

      During fixing of JENKINS-34669 I've discovered that Jenkins 2.1 bundles the obsolete version of jenkins-js-builder. The last release version is 0.0.51, but Jenkins core still bundles 0.0.40. It means the core does not get patches like this one: https://github.com/tfennelly/jenkins-js-modules/commit/dd98ceefcc28861b11272214aeb9bc32a3aaae62

      This fix is required to prevent fatal failures on module duplicates

      Background

      We have a plugin, which tweaks Jenkins UI before the startup in order to initialize some stuff (add extra plugins, etc.). So the plugin has an additional UI page. When I bundle this plugin into Jenkins.war, Jenkins 2.0 installation Wizard hangs infinitely.

According to the JS debugger, it happens due to the ""Jenkins global module 'pluginSetupWizard' already registered." error. There are stacktraces for the first and second export operations.

Jenkins WebUI should at least return an error for such failures. Ideally it should be robust agains such "hacks in plugins"

        1. firstCall.png
          305 kB
          Oleg Nenashev
        2. hangingInstallationWizard.png
          137 kB
          Oleg Nenashev
        3. secondCall.png
          278 kB
          Oleg Nenashev

            recena Manuel Recena Soto
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: