Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34835

GitHub team should be referenced by slug not name

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The GitHub OAuth plugin adds a user's organizations and teams as Jenkins groups when authenticating through GItHub.

      The pattern for teams is: organization.login*team.name

      Instead of team.name, Jenkins should store the group name as team.slug. Team slugs are unique per organization and are more URL path / script friendly.

      Reference: https://developer.github.com/v3/orgs/teams/#list-teams

        Attachments

          Issue Links

            Activity

            Hide
            sag47 Sam Gleske added a comment -

            Andy, have you had a chance to look at this further?

            Show
            sag47 Sam Gleske added a comment - Andy, have you had a chance to look at this further?
            Hide
            apemberton Andy Pemberton added a comment -

            Hey Sam Gleske: I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281, so should be an easy fix from here.

            Show
            apemberton Andy Pemberton added a comment - Hey Sam Gleske : I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281 , so should be an easy fix from here.
            Hide
            sag47 Sam Gleske added a comment -
            Show
            sag47 Sam Gleske added a comment - Fix in github-auth plugin https://github.com/jenkinsci/github-oauth-plugin/pull/116
            Hide
            sag47 Sam Gleske added a comment -

            Visiting localhost whoAmI page on test Jenkins instance revealed that https://github.com/jenkinsci/github-oauth-plugin/pull/116 was only a partial solution. It's not the full solution so the issue isn't fixed.

            Show
            sag47 Sam Gleske added a comment - Visiting localhost whoAmI page on test Jenkins instance revealed that https://github.com/jenkinsci/github-oauth-plugin/pull/116 was only a partial solution. It's not the full solution so the issue isn't fixed.

              People

              Assignee:
              sag47 Sam Gleske
              Reporter:
              apemberton Andy Pemberton
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: