Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34835

GitHub team should be referenced by slug not name

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • github-oauth-plugin
    • None
    • 0.24
    • 0.35

      The GitHub OAuth plugin adds a user's organizations and teams as Jenkins groups when authenticating through GItHub.

      The pattern for teams is: organization.login*team.name

      Instead of team.name, Jenkins should store the group name as team.slug. Team slugs are unique per organization and are more URL path / script friendly.

      Reference: https://developer.github.com/v3/orgs/teams/#list-teams

          [JENKINS-34835] GitHub team should be referenced by slug not name

          Sam Gleske added a comment -

          Andy, have you had a chance to look at this further?

          Sam Gleske added a comment - Andy, have you had a chance to look at this further?

          Hey sag47: I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281, so should be an easy fix from here.

          Andy Pemberton added a comment - Hey sag47 : I haven't, though it does appear the required PR was merged in the github-api project: https://github.com/kohsuke/github-api/pull/281 , so should be an easy fix from here.

          Sam Gleske added a comment -

          Sam Gleske added a comment - Fix in github-auth plugin https://github.com/jenkinsci/github-oauth-plugin/pull/116

          Sam Gleske added a comment -

          Visiting localhost whoAmI page on test Jenkins instance revealed that https://github.com/jenkinsci/github-oauth-plugin/pull/116 was only a partial solution. It's not the full solution so the issue isn't fixed.

          Sam Gleske added a comment - Visiting localhost whoAmI page on test Jenkins instance revealed that https://github.com/jenkinsci/github-oauth-plugin/pull/116 was only a partial solution. It's not the full solution so the issue isn't fixed.

          Basil Crow added a comment -

          Fixed in jenkinsci/github-oauth-plugin#124. Released in [https://github.com/jenkinsci/github-oauth-plugin/releases/tag/github-oauth-0.35|0.35].

          Basil Crow added a comment - Fixed in jenkinsci/github-oauth-plugin#124 . Released in [https://github.com/jenkinsci/github-oauth-plugin/releases/tag/github-oauth-0.35|0.35] .

            mancuniansam Sam Palmer
            apemberton Andy Pemberton
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: