• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • github-oauth-plugin
    • None
    • Jenkins 2.5
      Github Authentication plugin 0.23

      Plugin is not retrieving items from github, or it is not setting on user

          [JENKINS-34896] Not retrieving teams

          Sam Gleske added a comment -

          I think I understand how to fix this. This is a two part issue. The first is improperly checking for teams as a normal user (I know how to fix this). The other issue is related to JENKINS-34835 where teams are inconsistently referred by name instead of slug (slug is what it should be using). To understand the name vs slug check out the GitHub API response example in https://developer.github.com/v3/orgs/teams/#list-teams. I'll create a patch which helps address some of the exceptions.

          Sam Gleske added a comment - I think I understand how to fix this. This is a two part issue. The first is improperly checking for teams as a normal user (I know how to fix this). The other issue is related to JENKINS-34835 where teams are inconsistently referred by name instead of slug (slug is what it should be using). To understand the name vs slug check out the GitHub API response example in https://developer.github.com/v3/orgs/teams/#list-teams . I'll create a patch which helps address some of the exceptions.

          Code changed in jenkins
          User: Sam Gleske
          Path:
          src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
          http://jenkins-ci.org/commit/github-oauth-plugin/ee8b0370640658e9790358ce49b14445f9cfb74c
          Log:
          JENKINS-34896 Skip searching users when

          searching for teams.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java http://jenkins-ci.org/commit/github-oauth-plugin/ee8b0370640658e9790358ce49b14445f9cfb74c Log: JENKINS-34896 Skip searching users when searching for teams.

          Code changed in jenkins
          User: Sam Gleske
          Path:
          src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
          http://jenkins-ci.org/commit/github-oauth-plugin/72ddf25e435d5467fb5b928ceb45e7f6017b79fd
          Log:
          JENKINS-34896 Skip searching users when

          searching for teams.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java http://jenkins-ci.org/commit/github-oauth-plugin/72ddf25e435d5467fb5b928ceb45e7f6017b79fd Log: JENKINS-34896 Skip searching users when searching for teams.

          Code changed in jenkins
          User: Sam Gleske
          Path:
          src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
          http://jenkins-ci.org/commit/github-oauth-plugin/597ade3c6a49d77b9f36f2fa80e3ddf221e006d6
          Log:
          JENKINS-34896 Skip searching users when

          searching for teams.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java http://jenkins-ci.org/commit/github-oauth-plugin/597ade3c6a49d77b9f36f2fa80e3ddf221e006d6 Log: JENKINS-34896 Skip searching users when searching for teams.

          Code changed in jenkins
          User: Sam Gleske
          Path:
          src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
          http://jenkins-ci.org/commit/github-oauth-plugin/4bd1519cc2273c0ec4b211c487500039695ba59f
          Log:
          Merge pull request #68 from jenkinsci/JENKINS-34896

          JENKINS-34896 Skip searching users when searching for teams

          Compare: https://github.com/jenkinsci/github-oauth-plugin/compare/ce15460dda50...4bd1519cc227

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java http://jenkins-ci.org/commit/github-oauth-plugin/4bd1519cc2273c0ec4b211c487500039695ba59f Log: Merge pull request #68 from jenkinsci/ JENKINS-34896 JENKINS-34896 Skip searching users when searching for teams Compare: https://github.com/jenkinsci/github-oauth-plugin/compare/ce15460dda50...4bd1519cc227

          Code changed in jenkins
          User: Sam Gleske
          Path:
          CHANGELOG.md
          http://jenkins-ci.org/commit/github-oauth-plugin/c78dc42fd2f8f468f6ec1021e8ebc7473daf484b
          Log:
          update CHANGELOG

          [fixes JENKINS-16350]
          [fixes JENKINS-34896]
          [fixes JENKINS-39200]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: CHANGELOG.md http://jenkins-ci.org/commit/github-oauth-plugin/c78dc42fd2f8f468f6ec1021e8ebc7473daf484b Log: update CHANGELOG [fixes JENKINS-16350] [fixes JENKINS-34896] [fixes JENKINS-39200]

          Code changed in jenkins
          User: Sam Gleske
          Path:
          CHANGELOG.md
          http://jenkins-ci.org/commit/github-oauth-plugin/83f478099714eecefdfbe15068b83ccc905a4534
          Log:
          update CHANGELOG

          [fixes JENKINS-16350]
          [fixes JENKINS-34896]
          [fixes JENKINS-39200]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: CHANGELOG.md http://jenkins-ci.org/commit/github-oauth-plugin/83f478099714eecefdfbe15068b83ccc905a4534 Log: update CHANGELOG [fixes JENKINS-16350] [fixes JENKINS-34896] [fixes JENKINS-39200]

          Code changed in jenkins
          User: Sam Gleske
          Path:
          CHANGELOG.md
          http://jenkins-ci.org/commit/github-oauth-plugin/c175b45f6eab1ee86b1af28df7e7838f51521b1f
          Log:
          update CHANGELOG

          [fixes JENKINS-16350]
          [fixes JENKINS-34896]
          [fixes JENKINS-39200]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: CHANGELOG.md http://jenkins-ci.org/commit/github-oauth-plugin/c175b45f6eab1ee86b1af28df7e7838f51521b1f Log: update CHANGELOG [fixes JENKINS-16350] [fixes JENKINS-34896] [fixes JENKINS-39200]

          Code changed in jenkins
          User: Sam Gleske
          Path:
          CHANGELOG.md
          http://jenkins-ci.org/commit/github-oauth-plugin/85599d1b484328ce64bc4e21a79c9f43ed051a8c
          Log:
          update CHANGELOG

          [fixes JENKINS-16350]
          [fixes JENKINS-34896]
          [fixes JENKINS-39200]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: CHANGELOG.md http://jenkins-ci.org/commit/github-oauth-plugin/85599d1b484328ce64bc4e21a79c9f43ed051a8c Log: update CHANGELOG [fixes JENKINS-16350] [fixes JENKINS-34896] [fixes JENKINS-39200]

          Sam Gleske added a comment -

          This should be fixed. Release github-oauth 0.25.

          Sam Gleske added a comment - This should be fixed. Release github-oauth 0.25.

            sag47 Sam Gleske
            felipegs Felipe Santos
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: