-
Bug
-
Resolution: Fixed
-
Major
There are several problems with the way ping threads are set up.
- ChannelPinger sets up a master → agent ping, and also an agent → master ping. But Launcher sets up another slave → master ping for JNLP agents (not for master-initiated ones)...and is more awkward to disable, since you must pass a system property to each agent's launch line.
- As noted here, the agent → master ping from ChannelPinger does not work at all, due to a mistake in usage of PingFailureAnalyzer. (Oddly, kohsuke introduced this extension point claiming it could be implemented in ssh-slaves, but apparently never did so there, or anywhere else!)
- The Launcher variant fails to override the nondeprecated onDead variant that gets a stack trace.
- causes
-
JENKINS-70414 Ping thread failures on agent side were ignored
-
- Closed
-
- is duplicated by
-
JENKINS-34887 PingFailureAnalyzer NPE
-
- Resolved
-
- links to
(1 links to)
Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/hudson/slaves/ChannelPinger.java
http://jenkins-ci.org/commit/jenkins/0ae6c42ed2cbda0ea4a1e196656ef1d6008d80ba
Log:
JENKINS-35190Do not even consult PingFailureAnalyzer if ping fails on the agent side. (#2377)