Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35453

Allow disabling the default commit status notifier

      In JENKINS-33151, giving users the option to disable the default commit status notifier was raised (in lieu of more complex configuration, such as the ability to change the context string, which is hard-coded to 'Jenkins': https://github.com/jenkinsci/github-branch-source-plugin/blob/master@%7B2016-06-08%7D/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java#L78)

      I think there's probably a use case for this, and it would allow users with more complicated status logic (such as in that ticket) to implement their own, and just opt out of the default one.

          [JENKINS-35453] Allow disabling the default commit status notifier

          Jesse Glick added a comment -

          Cf. comment in JENKINS-26522.

          Jesse Glick added a comment - Cf. comment in JENKINS-26522 .

          Alex Ehlke added a comment -

          Just to chime in with one use case: we're incrementally rolling out Jenkinsfile for CI, and so we'd prefer to disable the commit status update while we're still prototyping. We want to be able to have Jenkinsfile run in parallel with our existing CI to build all branches, to test it at scale, but since it's still unproven for us we wouldn't want any issues to result in GitHub pull requests being marked as failed as we roll it out.

          We have workarounds, just wanted to provide one use case since you seemed uncertain about the value of this.

          Alex Ehlke added a comment - Just to chime in with one use case: we're incrementally rolling out Jenkinsfile for CI, and so we'd prefer to disable the commit status update while we're still prototyping. We want to be able to have Jenkinsfile run in parallel with our existing CI to build all branches, to test it at scale, but since it's still unproven for us we wouldn't want any issues to result in GitHub pull requests being marked as failed as we roll it out. We have workarounds, just wanted to provide one use case since you seemed uncertain about the value of this.

          Mike Robinson added a comment -

          In my case, I want to send a multiple github statuses, with context equal to the pipeline stage, so we can use protected branches, but only lock out failing lint and unit testing stages, not our experimental stages or deploy stages.

          I believe this would be a helpful for that sort of workflow.

          Mike Robinson added a comment - In my case, I want to send a multiple github statuses, with context equal to the pipeline stage, so we can use protected branches, but only lock out failing lint and unit testing stages, not our experimental stages or deploy stages. I believe this would be a helpful for that sort of workflow.

          Dmytro Baikov added a comment -

          +1 This feature would be very useful for us!

          We also have a need to send customized notifications to github with different context depending on the current build stage.

          Dmytro Baikov added a comment - +1 This feature would be very useful for us! We also have a need to send customized notifications to github with different context depending on the current build stage.

          marc young added a comment - - edited

          This bug is annoying my coworkers. We use a Jenkinsfile to test branches or deploy based on boolean parameter

          IS_DEPLOY

          Everything works great, except if you deploy jenkins sends a pass/fail to the branch/PR which isn't what I want, i only care that the tests send that pass/fail.

          marc young added a comment - - edited This bug is annoying my coworkers. We use a Jenkinsfile to test branches or deploy based on boolean parameter IS_DEPLOY Everything works great, except if you deploy jenkins sends a pass/fail to the branch/PR which isn't what I want, i only care that the tests send that pass/fail.

          Sparkle Pony added a comment -

          I'd also like to give a +1 that it's a bummer I can't turn these off. I'm using my own custom notification, so having these in there as well creates confusing clutter that I have to explain to my coworkers.

          Sparkle Pony added a comment - I'd also like to give a +1 that it's a bummer I can't turn these off. I'm using my own custom notification, so having these in there as well creates confusing clutter that I have to explain to my coworkers.

          I can see the PR has been closed. Are there still plans to implement this improvement ? stephenconnolly vlatombe

          Allan BURDAJEWICZ added a comment - I can see the PR has been closed. Are there still plans to implement this improvement ? stephenconnolly vlatombe

          James Dumay added a comment -

          There is a plugin that can provide this as a trait to the Github branch source.

          https://github.com/bluesliverx/disable-github-multibranch-status-plugin

          James Dumay added a comment - There is a plugin that can provide this as a trait to the Github branch source. https://github.com/bluesliverx/disable-github-multibranch-status-plugin

          Alexander Komarov added a comment - - edited

          I didn't notice this ticket until now - I just implemented a somewhat more flexible version of this as a PR to github-branch-source in JENKINS-48408 (oops).

          https://github.com/jenkinsci/github-branch-source-plugin/pull/169

          The advantage is that you get an option to hide the Jenkins URL but still have notifications in github.

          Alexander Komarov added a comment - - edited I didn't notice this ticket until now - I just implemented a somewhat more flexible version of this as a PR to github-branch-source in  JENKINS-48408 (oops). https://github.com/jenkinsci/github-branch-source-plugin/pull/169 The advantage is that you get an option to hide the Jenkins URL but still have notifications in github.

          This is unfortunate to see this isn't implemented.  I think this is a use case that is strong enough to be documented.  There is no mention on the documentation on how to turn this automatic setting off: https://go.cloudbees.com/docs/plugins/github-branch-source/

           

          Also most of us working with setting our own status's are using this plugin documentation: https://plugins.jenkins.io/github

           

          So basically we have 2 plugins at play now to do proper customized commit status's.  Now for us to turn off the default Status, we need to use a third one from jamesdumay.

           

           

          While I realize this is resolved, one must ask, why is this level of customization (3) plugins required to send only the notifications I want to Github when using the github-branch-source plugin....?  As usual, yes make the defaults easy for new users, but asking for an ability to turn off a default (default status notification) seems prudent from the end user community trying to customize their business's workflow.

          Nick Carpenter added a comment - This is unfortunate to see this isn't implemented.  I think this is a use case that is strong enough to be documented.  There is no mention on the documentation on how to turn this automatic setting off: https://go.cloudbees.com/docs/plugins/github-branch-source/   Also most of us working with setting our own status's are using this plugin documentation: https://plugins.jenkins.io/github   So basically we have 2 plugins at play now to do proper customized commit status's.  Now for us to turn off the default Status, we need to use a third one from jamesdumay .     While I realize this is resolved, one must ask, why is this level of customization (3) plugins required to send only the notifications I want to Github when using the github-branch-source plugin....?  As usual, yes make the defaults easy for new users, but asking for an ability to turn off a default (default status notification) seems prudent from the end user community trying to customize their business's workflow.

            vlatombe Vincent Latombe
            dominics Dominic Scheirlinck
            Votes:
            13 Vote for this issue
            Watchers:
            28 Start watching this issue

              Created:
              Updated:
              Resolved: