vpandey The parallel blocks handling seems reasonable (though I think it needs to define handling for other combinations of states in a similar fashion).
> I don't think we are handling these at the moment. So NotExecuted is something thats going to be executed eventually?
No, NotExecuted is set on all steps skipped when you resume from a checkpoint - those steps are never executed (since the checkpoint resume takes care of their results). It's a separate state (stage view has handling for this), and it needs to be handled if we are going to support the CJP value-add in cloudbees workflow plugin.
> This behavior sounds correct. Why are we marking that step as failure? IMO, user is explicitly declaring try/catch, that tells pipeline machinery should not flag it as ErrorAction.
That was my impression too - if the error is caught, the step should either not get an ErrorAction, or it should have some marker to indicate that it the error was caught. Of course there is more than one school of thought on this matter unfortunately.
vpandey The parallel blocks handling seems reasonable (though I think it needs to define handling for other combinations of states in a similar fashion).
> I don't think we are handling these at the moment. So NotExecuted is something thats going to be executed eventually?
No, NotExecuted is set on all steps skipped when you resume from a checkpoint - those steps are never executed (since the checkpoint resume takes care of their results). It's a separate state (stage view has handling for this), and it needs to be handled if we are going to support the CJP value-add in cloudbees workflow plugin.
> This behavior sounds correct. Why are we marking that step as failure? IMO, user is explicitly declaring try/catch, that tells pipeline machinery should not flag it as ErrorAction.
That was my impression too - if the error is caught, the step should either not get an ErrorAction, or it should have some marker to indicate that it the error was caught. Of course there is more than one school of thought on this matter unfortunately.