• 1.0-m10, 1.0-b05/b-06

      Design Brief
      Blue Ocean makes a lot of asynchronous rest calls and any of them could fail at any time.

      There are two cases here I think we need to handle:

      • When a whole page fails to render
      • When one of the AJAX calls fails with 500/503/502 we should show the error screen

      In Scope

      • Design for both the cases above
      • Decide what our error reporting should look like across the app.

      Design

          [JENKINS-36083] Improve Error handling

          Keith Zantow added a comment - - edited

          @brody Not very fond of the loading error, it's not very noticeable (from experience using the toasts during running, of course somewhat subjective - the normal spot for toasts is on the top) it doesn't look like an error, and the likelihood a reload would actually fix it is low, it's probably due to a data change on the back end.

          Keith Zantow added a comment - - edited @brody Not very fond of the loading error, it's not very noticeable (from experience using the toasts during running, of course somewhat subjective - the normal spot for toasts is on the top) it doesn't look like an error, and the likelihood a reload would actually fix it is low, it's probably due to a data change on the back end.

          Brody Maclean added a comment -

          kzantow The user will have their eyes at the bottom of the page when the click the "load more" button and the toast will fade in and slide in from the left. The motion plus position relative to the users focus should be more than enough to draw the users attention.

          Top right wont work because of the nav bar, but would be worth exploring if we go down the road of a left hand vertical nav.

          Brody Maclean added a comment - kzantow The user will have their eyes at the bottom of the page when the click the "load more" button and the toast will fade in and slide in from the left. The motion plus position relative to the users focus should be more than enough to draw the users attention. Top right wont work because of the nav bar, but would be worth exploring if we go down the road of a left hand vertical nav.

          Keith Zantow added a comment -

          brody this is going to be shown for all kinds of operations. most likely is if they click an executing pipeline, which would be at the top of the page. I also don't buy someone's view being in a certain place argument, it may take some time for the failure to happen, which would shift it.

          Keith Zantow added a comment - brody this is going to be shown for all kinds of operations. most likely is if they click an executing pipeline, which would be at the top of the page. I also don't buy someone's view being in a certain place argument, it may take some time for the failure to happen, which would shift it.

          Brody Maclean added a comment -

          kzantow A toast makes sense in this situation. We'll test it with users to make sure it works for them.

          An alert that sits at the top would make sense for other situations, but it would be out of view when the user scrolls down. http://i.brody.com/ikGN

          Brody Maclean added a comment - kzantow A toast makes sense in this situation. We'll test it with users to make sure it works for them. An alert that sits at the top would make sense for other situations, but it would be out of view when the user scrolls down. http://i.brody.com/ikGN

          Keith Zantow added a comment -

          Ok, I'm all for 'testing with users', but c'mon, an error should look like an error. This situation is always on screen, toasts always show onscreen, they're fixed, typically showing up at the top but that's a fight for a different day - our toasts show up at the bottom, ok, but it needs to look like an error, this looks like a run starts, click to go see it.

          Keith Zantow added a comment - Ok, I'm all for 'testing with users', but c'mon, an error should look like an error. This situation is always on screen, toasts always show onscreen , they're fixed, typically showing up at the top but that's a fight for a different day - our toasts show up at the bottom, ok, but it needs to look like an error, this looks like a run starts, click to go see it.

          Keith Zantow added a comment - - edited

          Sorry if that came across inflammatory, not the intention... just that I firmly believe errors should have some sort of visual indication there's an error.

          Keith Zantow added a comment - - edited Sorry if that came across inflammatory, not the intention... just that I firmly believe errors should have some sort of visual indication there's an error.

          James Dumay added a comment -

          Keith there is another design coming soon to make the toasts look more like errrors in this case. Expect to see it in 1.0.x (or sooner if we get through our reduced backlog)

          James Dumay added a comment - Keith there is another design coming soon to make the toasts look more like errrors in this case. Expect to see it in 1.0.x (or sooner if we get through our reduced backlog)

          Brody Maclean added a comment -

          We're rolling with the existing toast for now & we'll circle back and make it a little more errory down the line. Something like the below.

          Brody Maclean added a comment - We're rolling with the existing toast for now & we'll circle back and make it a little more errory down the line. Something like the below.

          Keith Zantow added a comment -

          Looking good. Saw this with the connection lost, it's at least error-ish.

          Keith Zantow added a comment - Looking good. Saw this with the connection lost, it's at least error-ish.

          James Dumay added a comment -

          kzantow yeah that actually hides a lot of sins in the error handling so we are pushing this out post-release.

          James Dumay added a comment - kzantow yeah that actually hides a lot of sins in the error handling so we are pushing this out post-release.

            imeredith Ivan Meredith
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: