Handle errors and 404s consistently

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      In scope
      If the run result is opened and no run or job exists it should go to the 404 page.

      Follow up work of JENKINS-39809, this part should cover:

      • mobx returns always an answer
      • response object should contain at least data and error attributes, maybe a generic state as well
      const pager = { data, error, state }
      
      // then in view
      
      if (pager.error) {
        return <NotFound/>;
      }
      
      // and to get rid of pager.$pending
      if (pager.state === 'PENDING') {
       return null;
      }
      
      • use this new code to fix 404 with patterns
       '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline'
      

      where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists.

      dogfood context
      https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/

            Assignee:
            Unassigned
            Reporter:
            Thorsten Scherler
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: