Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36121

Github Branch Source plugin trips api rate limit

XMLWordPrintable

      We have quite a large organization in Github, lots of repos with lots of branches. Running the organization scan works well for a while, and then begins erroring out with

      org.jenkinsci.plugins.github_branch_source.RateLimitExceededException: GitHub API rate limit exceeded

      This is pretty rough since it always starts in the same place, and I haven't been able to figure out ANY way to add a project from the back of the list that recently added a Jenkinsfile. I am using a valid set of credentials (all the repos are private, so it wouldn't work otherwise anyway).

        1. API Usage with new plugins.png
          API Usage with new plugins.png
          23 kB
        2. API Usage with original plugins.png
          API Usage with original plugins.png
          23 kB
        3. branch-api.hpi
          234 kB
        4. cloudbees-folder.hpi
          185 kB
        5. github-api.hpi
          2.01 MB
        6. github-api.hpi
          2.01 MB
        7. github-branch-source.hpi
          1.70 MB
        8. github-branch-source.hpi
          1.70 MB
        9. github-branch-source.hpi
          1.70 MB
        10. github-branch-source.hpi
          1.70 MB
        11. screenshot-1.png
          screenshot-1.png
          39 kB
        12. Screen Shot 2017-02-22 at 17.26.37.png
          Screen Shot 2017-02-22 at 17.26.37.png
          84 kB

          [JENKINS-36121] Github Branch Source plugin trips api rate limit

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubClosable.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFile.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMProbe.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/8a393a4231a4eda81cd4f931d9bc07804713543d
          Log:
          JENKINS-36121 Throttle API usage rather than trip the API limit

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubClosable.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFile.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMProbe.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8a393a4231a4eda81cd4f931d9bc07804713543d Log: JENKINS-36121 Throttle API usage rather than trip the API limit

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/e090ce41073979674cec4774bf9348c2aa74dc25
          Log:
          JENKINS-36121 Save rate limits when processing events

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java http://jenkins-ci.org/commit/github-branch-source-plugin/e090ce41073979674cec4774bf9348c2aa74dc25 Log: JENKINS-36121 Save rate limits when processing events

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/c16c1f4dabbe08feda6f8661772c7bad62334bbf
          Log:
          JENKINS-36121 Actually don't even waste the API calls listing repositories for the common event case

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java http://jenkins-ci.org/commit/github-branch-source-plugin/c16c1f4dabbe08feda6f8661772c7bad62334bbf Log: JENKINS-36121 Actually don't even waste the API calls listing repositories for the common event case

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/b025751381452800809847d9585f5f356a38d9ac
          Log:
          JENKINS-36121 Typos

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java http://jenkins-ci.org/commit/github-branch-source-plugin/b025751381452800809847d9585f5f356a38d9ac Log: JENKINS-36121 Typos

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/fcafab8f42b55bcb2dbc6383f7ce01b29810cd98
          Log:
          JENKINS-36121 Review comments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java http://jenkins-ci.org/commit/github-branch-source-plugin/fcafab8f42b55bcb2dbc6383f7ce01b29810cd98 Log: JENKINS-36121 Review comments

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/b59c83dbab0ef203bf930e5cbde49796ddc609b9
          Log:
          JENKINS-36121 Clarifying comments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java http://jenkins-ci.org/commit/github-branch-source-plugin/b59c83dbab0ef203bf930e5cbde49796ddc609b9 Log: JENKINS-36121 Clarifying comments

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubClosable.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFile.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMProbe.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/2b7a7f955978c275892c10460d2c4351ff400cb8
          Log:
          Merge pull request #124 from stephenc/jenkins-36121

          JENKINS-36121 Do not trip the rate limit

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/1dbf190e3c29...2b7a7f955978

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubClosable.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConsoleNote.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFile.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMProbe.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/2b7a7f955978c275892c10460d2c4351ff400cb8 Log: Merge pull request #124 from stephenc/jenkins-36121 JENKINS-36121 Do not trip the rate limit Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/1dbf190e3c29...2b7a7f955978

          Stephen Connolly added a comment -

          Released as 2.0.4-beta-1 and available via the experimental update center.

          Assuming our (CloudBees) soak tests and any other community contributed test results are successful, this should be released to the general update center in the next couple of days.

          This is your last chance to provide feedback before this is incorporated into a mainline release

          Stephen Connolly added a comment - Released as 2.0.4-beta-1 and available via the experimental update center. Assuming our (CloudBees) soak tests and any other community contributed test results are successful, this should be released to the general update center in the next couple of days. This is your last chance to provide feedback before this is incorporated into a mainline release

          Mariusz added a comment -

          Works for me so far

          Mariusz added a comment - Works for me so far

          Stephen Connolly added a comment -

          Released as 2.0.4

          Stephen Connolly added a comment - Released as 2.0.4

            stephenconnolly Stephen Connolly
            pbecot01 Paul Becotte
            Votes:
            27 Vote for this issue
            Watchers:
            50 Start watching this issue

              Created:
              Updated:
              Resolved: