Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36171

Steps with no logs should not be expandable

    XMLWordPrintable

Details

    • 1.0-pre-beta-1

    Description

      Some steps do not come with logs

      Example

      It would be good if we had a similar style for any log that was not expandable. Steps that were not run in storybook have a style that could be reused.

      In the case of steps with no logs we should hide the expander icon.

      Attachments

        Issue Links

          Activity

            jamesdumay James Dumay added a comment -

            Can we make stats on those files cheap? Whats the penalty?

            jamesdumay James Dumay added a comment - Can we make stats on those files cheap? Whats the penalty?
            vivek Vivek Pandey added a comment -

            jamesdumay We get it from core, looking at the code it does File.length(), not sure how performant it is underneath. Keeping performance thing aside, that is even if for each step we give log file length size, it will only work for complete steps. for steps in progress or not yet run the log file length could be zero in that snapshot but later might or might not produce any log. so how do you intend to handle that case?

            vivek Vivek Pandey added a comment - jamesdumay We get it from core, looking at the code it does File.length(), not sure how performant it is underneath. Keeping performance thing aside, that is even if for each step we give log file length size, it will only work for complete steps. for steps in progress or not yet run the log file length could be zero in that snapshot but later might or might not produce any log. so how do you intend to handle that case?
            michaelneale Michael Neale added a comment -

            Right, if we don't know up front it has no log, I don't think we can do anything "nicely", and we just live with it.

            There are common steps that don't have a log and we know that up front, and the change set for this addresses that, which is enough for me.

            michaelneale Michael Neale added a comment - Right, if we don't know up front it has no log, I don't think we can do anything "nicely", and we just live with it. There are common steps that don't have a log and we know that up front, and the change set for this addresses that, which is enough for me.

            Code changed in jenkins
            User: Thorsten Scherler
            Path:
            src/test/js/log-karaoke/noStages.js
            src/test/resources/test_scripts/no-stages.groovy
            http://jenkins-ci.org/commit/blueocean-acceptance-test/ca4cd5454f2d24a0f1af1e99ed5c8d390363f31c
            Log:
            Jenkins 36171 Steps with no logs should not be expandable (#24)

            • Debug logging of SSE events
            • More on logging (client and server side)
            • Better SSE connection disconnect cleanup
            • Update to latest SSE gateway client api
            • Use a relative path to logging.properties file
            • Remove misleading seleium docs in readme (#11)
            • [master] Fix last test by turning on cssPath again before finishing last test
            • [master] try to fix freestyle error validation on server
            • [master] comment the flaky test until I come up with something better. stop karaoke is covered in other tests as well
            • [master] Add more comments to code
            • [master] Change test to test positive. stop karaoke via keyUp is tested in noStage
            • JENKINS-36171 implement test to see that steps that do not have logs neither are expandable
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/test/js/log-karaoke/noStages.js src/test/resources/test_scripts/no-stages.groovy http://jenkins-ci.org/commit/blueocean-acceptance-test/ca4cd5454f2d24a0f1af1e99ed5c8d390363f31c Log: Jenkins 36171 Steps with no logs should not be expandable (#24) Debug logging of SSE events More on logging (client and server side) Better SSE connection disconnect cleanup Update to latest SSE gateway client api Use a relative path to logging.properties file Remove misleading seleium docs in readme (#11) [master] Fix last test by turning on cssPath again before finishing last test [master] try to fix freestyle error validation on server [master] comment the flaky test until I come up with something better. stop karaoke is covered in other tests as well [master] Add more comments to code [master] Change test to test positive. stop karaoke via keyUp is tested in noStage JENKINS-36171 implement test to see that steps that do not have logs neither are expandable

            michaelneale yeah as @vivek stated we would need to actually fetch the log (at least the header) and see whether length is >0 and then could decide about the caret, however that is IMO way too much effort for the one/two steps that COULD provide a log but do not use that.

            tscherler Thorsten Scherler added a comment - michaelneale yeah as @vivek stated we would need to actually fetch the log (at least the header) and see whether length is >0 and then could decide about the caret, however that is IMO way too much effort for the one/two steps that COULD provide a log but do not use that.

            People

              tscherler Thorsten Scherler
              jamesdumay James Dumay
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: