Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36851

Favourite stars should be hidden for the anonymous user

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • blueocean-plugin
    • None
    • 1.0-pre-beta-1

      Favouriting does not work for anonymous users so this action should be hidden from them.

          [JENKINS-36851] Favourite stars should be hidden for the anonymous user

          James Dumay added a comment -

          cliffmeyers I also noticed if there are no extension points in that column that we show a blank space for these? Could we make that space go away if there are no extension points?

          James Dumay added a comment - cliffmeyers I also noticed if there are no extension points in that column that we show a blank space for these? Could we make that space go away if there are no extension points?

          Cliff Meyers added a comment -

          PR: https://github.com/jenkinsci/blueocean-plugin/pull/409

          Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/409

          Cliff Meyers added a comment -

          jamesdumay yes, but not easily right now. That space is controlled by an explicit width set on the TH element which forces the entire column to a certain size. We probably need to remove that, and add some logic to the Extensions.Renderer to apply a vertical / horizontal layout and handle wrapping of multiple elements, etc. I would split out a separate ticket because it's sort of a non-trivial amount of work to deal with what's just a small spacing issue right now.

          Cliff Meyers added a comment - jamesdumay yes, but not easily right now. That space is controlled by an explicit width set on the TH element which forces the entire column to a certain size. We probably need to remove that, and add some logic to the Extensions.Renderer to apply a vertical / horizontal layout and handle wrapping of multiple elements, etc. I would split out a separate ticket because it's sort of a non-trivial amount of work to deal with what's just a small spacing issue right now.

            cliffmeyers Cliff Meyers
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: