Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3721

Job-enabling API should reject GET requests

    XMLWordPrintable

Details

    • Patch
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None
    • Platform: All, OS: All

    Description

      According to job API description, job-enabling/disabling APIs should be invoked
      by POST requests.
      But in doEnable in AbstractProject.java, the job-enabling API is invoked by a
      GET request.

      Attachments

        Activity

          Created an attachment (id=711)
          add requirePOST to doEnable

          ohtake_tomohiro OHTAKE Tomohiro added a comment - Created an attachment (id=711) add requirePOST to doEnable

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/AbstractModelObject.java
          trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=22207
          Log:
          [FIXED JENKINS-3721] Job-enabling API should reject GET requests.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/AbstractModelObject.java trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=22207 Log: [FIXED JENKINS-3721] Job-enabling API should reject GET requests.

          People

            Unassigned Unassigned
            ohtake_tomohiro OHTAKE Tomohiro
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: