Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37546

When dynamic plugin load fails, PermissionGroups are not being cleaned up

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core
    • jenkins-2.16

      Noticed it during JENKINS-37545.

      Reproduction steps:
      1) Manually deploy a plugin with detached dependencies and permission groups (e.g. Ownership 0.5)
      2) The loading should fail...
      3) Install missing dependencies
      4) Deploy the plugin again
      5) Change the log

      Expected behavior:
      The plugin installation succeeds

      Actual behavior:
      Plugin installation fails due to the missing permission group

      Workaround:
      Restart the instance

        1. Screen Shot 2016-08-19 at 13.39.31.png
          Screen Shot 2016-08-19 at 13.39.31.png
          424 kB

          [JENKINS-37546] When dynamic plugin load fails, PermissionGroups are not being cleaned up

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Attachment New: Screen Shot 2016-08-19 at 13.24.21.png [ 33656 ]
          Oleg Nenashev made changes -
          Attachment Original: Screen Shot 2016-08-19 at 13.24.21.png [ 33656 ]
          Oleg Nenashev made changes -
          Attachment New: Screen Shot 2016-08-19 at 13.39.31.png [ 33657 ]
          Oleg Nenashev made changes -
          Summary Original: When dynamic plugin loading fails, PermissionGroups are not being cleaned up New: When dynamic plugin load fails, PermissionGroups are not being cleaned up

          Jesse Glick added a comment -

          Probably should be fixed implicitly by a rewrite of permission registration, as mentioned in JENKINS-17200.

          Jesse Glick added a comment - Probably should be fixed implicitly by a rewrite of permission registration, as mentioned in JENKINS-17200 .
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-17200 [ JENKINS-17200 ]
          Isaac Aymerich made changes -
          Environment Original: jenkins-2.16 New: jenkins-2.16
          jenkins-2.17
          Isaac Aymerich made changes -
          Environment Original: jenkins-2.16
          jenkins-2.17
          		 New: jenkins-2.16

          Matt Sicker added a comment -

          In my current proposal around permissions, this error wouldn't happen as permissions are loaded lazily. Before that, I also had a ConcurrentMap for registering permissions, so even that was using putIfAbsent to avoid duplicating permissions in the UI.

          Matt Sicker added a comment - In my  current proposal around permissions, this error wouldn't happen as permissions are loaded lazily. Before that, I also had a ConcurrentMap for registering permissions, so even that was using putIfAbsent to avoid duplicating permissions in the UI.

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: