Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37831

Favoriting on Matrix style project broken

    XMLWordPrintable

Details

    • 1.0-beta-1, pacific, 1.0-b05/b-06

    Description

      Favoriting a matrix project computes incorrect URL to favorite, http://localhost:8080/jenkins/job/mc1/favorite/, notice 'job' in the path. this results in 404, however favorite icon is turned ON, favorited matrix project doesn't show up in list of favorited, clicking on it again gives 404 and favorite icon is removed.

      Attachments

        Issue Links

          Activity

            vivek Vivek Pandey added a comment -

            Removed my name from assigned, its an UI issue where something in UI is generating path to classic job.

            vivek Vivek Pandey added a comment - Removed my name from assigned, its an UI issue where something in UI is generating path to classic job.
            cliffmeyers Cliff Meyers added a comment -

            vivek we use the favorite item's self.href to build the URI to save the favorite. Unfortunately the matrix job is returning a classic URI for its self.href. Is that the kind of semantics we want? It seems inappropriate that some objects' self.href is to its valid REST URI and other objects self.href is to the Jenkins classic UI. Perhaps we can use a capability to express "classic only" jobs and add special entry in "_links" to the classic URI?

            cliffmeyers Cliff Meyers added a comment - vivek we use the favorite item's self.href to build the URI to save the favorite. Unfortunately the matrix job is returning a classic URI for its self.href. Is that the kind of semantics we want? It seems inappropriate that some objects' self.href is to its valid REST URI and other objects self.href is to the Jenkins classic UI. Perhaps we can use a capability to express "classic only" jobs and add special entry in "_links" to the classic URI?
            vivek Vivek Pandey added a comment -

            cliffmeyers Oh, that would be a bug in the backend, I will put a fix and get back to you.

            vivek Vivek Pandey added a comment - cliffmeyers Oh, that would be a bug in the backend, I will put a fix and get back to you.
            vivek Vivek Pandey added a comment -

            cliffmeyers Sorry for jumping, the legacy URL for matrix build is for a reason - that is if its matrix project then when user clicks on it, UI should redirect to classic UI for matrix project. See https://issues.jenkins-ci.org/browse/JENKINS-37427. Basically, if its matrix project (capability hudson.matrix.MatrixProject) then maybe favorite should be disabled. jamesdumay what do you think?

            vivek Vivek Pandey added a comment - cliffmeyers Sorry for jumping, the legacy URL for matrix build is for a reason - that is if its matrix project then when user clicks on it, UI should redirect to classic UI for matrix project. See https://issues.jenkins-ci.org/browse/JENKINS-37427 . Basically, if its matrix project (capability hudson.matrix.MatrixProject) then maybe favorite should be disabled. jamesdumay what do you think?
            jamesdumay James Dumay added a comment -

            vivek cliffmeyers disabling favourites on matrix SGTM

            jamesdumay James Dumay added a comment - vivek cliffmeyers disabling favourites on matrix SGTM
            vivek Vivek Pandey added a comment -

            cliffmeyers Assigning back to you

            vivek Vivek Pandey added a comment - cliffmeyers Assigning back to you
            cliffmeyers Cliff Meyers added a comment -

            Ok that makes sense.

            cliffmeyers Cliff Meyers added a comment - Ok that makes sense.
            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/497

            People

              cliffmeyers Cliff Meyers
              vivek Vivek Pandey
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: