Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47835

Favoriting a matrix job breaks blueocean favourites

XMLWordPrintable

    • Blue Ocean 1.4 - beta 3

      Symptoms

      Favorites disappear from front page of blueocean after adding a multi-configuration job as a favorite.

      Note: multi-configuration and matrix appear to be used interchangeably as names - but the UI refers to it as multi-configuration.  

      Expected Behaviour

      Stop me from favoriting / make favourites work with multiconfiguration

      Reproduction Steps

      • Create multi-configuration job
      • Favourite multi-configuration job
      • Refresh /blue

      Exceptions

      /adjuncts/6026ec5f/org/jenkins/ui/jsmodules/blueocean-personalization/jenkins-js-extension.js:25954 TypeError: Cannot read property 'toLowerCase' of undefined
    at TimeHarmonizerUtil.getI18nTitle (blueocean.js:2274)
    at LiveStatusIndicator.render (blueocean.js:1563)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (blueocean.js:124456)
    at ReactCompositeComponentWrapper._renderValidatedComponent (blueocean.js:124479)
    at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:124021)
    at ReactCompositeComponentWrapper.mountComponent (blueocean.js:123917)
    at Object.mountComponent (blueocean.js:130930)
    at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:124030)
    at ReactCompositeComponentWrapper.mountComponent (blueocean.js:123917)
    at Object.mountComponent (blueocean.js:130930)
    at ReactDOMComponent.mountChildren (blueocean.js:129808)
    at ReactDOMComponent._createInitialChildren (blueocean.js:125384)
    at ReactDOMComponent.mountComponent (blueocean.js:125209)
    at Object.mountComponent (blueocean.js:130930)
    at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:124030)
    at ReactCompositeComponentWrapper.mountComponent (blueocean.js:123917)
    at Object.mountComponent (blueocean.js:130930)
    at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:124030)
    at ReactCompositeComponentWrapper.mountComponent (blueocean.js:123917)
    at Object.mountComponent (blueocean.js:130930)
    at ReactDOMComponent.mountChildren (blueocean.js:129808)
    at ReactDOMComponent._createInitialChildren (blueocean.js:125384)
    
blueocean.js:149548 Unhandled Rejection:  TypeError: Expected Array or iterable object of values: TypeError: Cannot read property 'toLowerCase' of undefined
    at indexedSeqFromValue (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/immutable/immutable-3-8-1.js:1917)
    at IndexedSeq (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/immutable/immutable-3-8-1.js:1655)
    at IndexedIterable (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/immutable/immutable-3-8-1.js:1386)
    at new List (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/immutable/immutable-3-8-1.js:3410)
    at Object.SET_FAVORITES (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/blueocean-personalization/jenkins-js-extension.js:26019)
    at reducer (/adjuncts/6026ec5f/org/jenkins/ui/jsmodules/blueocean-personalization/jenkins-js-extension.js:26112)
    at combination (blueocean.js:138209)
    at dispatch (blueocean.js:138438)
    at blueocean.js:137956
    at dispatch (blueocean.js:138011)
    at /adjuncts/6026ec5f/org/jenkins/ui/jsmodules/blueocean-personalization/jenkins-js-extension.js:25956
    at <anonymous>

          [JENKINS-47835] Favoriting a matrix job breaks blueocean favourites

          Ben Walding added a comment -

          Looks like this has bitten blueocean in the past on JENKINS-37831.

          JENKINS-47492 may be related - their job has "matrix" in the name - so it's highly likely that it's a multiconfiguration / matrix job.

          Ben Walding added a comment - Looks like this has bitten blueocean in the past on JENKINS-37831 . JENKINS-47492 may be related - their job has "matrix" in the name - so it's highly likely that it's a multiconfiguration / matrix job.

          Ben Walding added a comment -

          I would have favorited it in Jenkins classic - as I'm not able to favorite in blueocean.

          Ben Walding added a comment - I would have favorited it in Jenkins classic - as I'm not able to favorite in blueocean.

          Josh McDonald added a comment -

          Still looking into this, it seems Stapler isn't marshalling the latestRun property correctly. I've asked Vivek for some pointers and will update again when I know more.

          Josh McDonald added a comment - Still looking into this, it seems Stapler isn't marshalling the latestRun property correctly. I've asked Vivek for some pointers and will update again when I know more.

          James Dumay added a comment -

          Not going to support multi-config jobs.

          James Dumay added a comment - Not going to support multi-config jobs.

          Josh McDonald added a comment -

          https://github.com/jenkinsci/blueocean-plugin/pull/1553

          Josh McDonald added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/1553

          Karl Shultz added a comment -

          Testing Notes:

          • There are already tests included as part of the PR.

          Karl Shultz added a comment - Testing Notes: There are already tests included as part of the PR .

          Josh McDonald added a comment -

          Fix in master at e373dce8628ffb5a14ace57e7aba894b8cdb1bdf

          Josh McDonald added a comment - Fix in master at e373dce8628ffb5a14ace57e7aba894b8cdb1bdf

            sophistifunk Josh McDonald
            bwalding Ben Walding
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: