Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37962

REGRESSION: parallel karaoke not allowing branch selection or completing correctly

    XMLWordPrintable

Details

    • 1.0-beta-1, 1.0-b05/b-06

    Description

      When running a pipeline that has parallel branches:

      • Selecting the non "top" branch doesn't show its steps
      • If a branch finishes early it doesn't show up as finished (likely related to above).

      A video of this in action:

      http://www.giphy.com/gifs/3oz8xx6ntQKUdBXf7W

      To reproduce, use the following in an simple non multibranch pipeline, run it from blue ocean and follow along: 

      node {
    stage "hey"
    sh "echo yeah"
    sleep 3
    
    stage "par"
    
    parallel (
        "left" : {
            sh "sleep 10s"
            sh "echo yeah"
        }, 
        
        "right" : {
            sh "echo wozzle"
        }
        
        )
    
    stage "ho"
    sh "echo done"
}

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-38360 Not receiving enough events (SSE) for block scoped stages

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37753 REGRESSION: Steps showing up as incomplete when they are in fact complete

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 36 older comments
            michaelneale Michael Neale added a comment - - edited

            tscherler are you able to try this branch: https://github.com/jenkinsci/blueocean-plugin/tree/vivek-sse-missing-stage-event-fix with this fix - see if it helps?

            EDIT: I tried with that branch, it didn't fix it, unfortunately (I didn't check the api results, just the UX, and there was no change).

            michaelneale Michael Neale added a comment - - edited tscherler are you able to try this branch: https://github.com/jenkinsci/blueocean-plugin/tree/vivek-sse-missing-stage-event-fix with this fix - see if it helps? EDIT: I tried with that branch, it didn't fix it, unfortunately (I didn't check the api results, just the UX, and there was no change).
            michaelneale Michael Neale added a comment -

            tscherler looks like we have to park this due to blocking issue. I believe the "parallel branch not completing correctly" is blcoked by another issue with pipeline (I don't have a link) so not much else can be done on this right now for you so this has to be put aside.

            michaelneale Michael Neale added a comment - tscherler looks like we have to park this due to blocking issue. I believe the "parallel branch not completing correctly" is blcoked by another issue with pipeline (I don't have a link) so not much else can be done on this right now for you so this has to be put aside.
            michaelneale Michael Neale added a comment - - edited

            tscherler so looks like PR solves all but the "branch completing correctly status" - which I think has a problem elsewhere (ie when one branch completes successfully, it doesn't show up in the flownode until both have completed).

            EDIT: https://issues.jenkins-ci.org/browse/JENKINS-38223 - is the linked issue for not showing as completed.

            So if this PR is merged, this could be close IMO

            michaelneale Michael Neale added a comment - - edited tscherler so looks like PR solves all but the "branch completing correctly status" - which I think has a problem elsewhere (ie when one branch completes successfully, it doesn't show up in the flownode until both have completed). EDIT: https://issues.jenkins-ci.org/browse/JENKINS-38223 - is the linked issue for not showing as completed. So if this PR is merged, this could be close IMO
            tscherler Thorsten Scherler added a comment -

            michaelNeale yeah but it is my understanding that this is a problem of the backend.

            tscherler Thorsten Scherler added a comment - michaelNeale yeah but it is my understanding that this is a problem of the backend.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Thorsten Scherler
            Path:
            src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
            src/test/js/log-karaoke/noStages.js
            src/test/js/log-karaoke/parallelStages.js
            src/test/resources/test_scripts/parallel-stages.groovy
            http://jenkins-ci.org/commit/blueocean-acceptance-test/c15815cbf7dd7c3116e162a4322d9b7bf245e425
            Log:
            FIX Jenkins-37962 REGRESSION: parallel karaoke not allowing branch selection or completing correctly (#42)

            • JENKINS-37962 Add test for clicking on run button then on the emerging toast the open
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/log-karaoke/noStages.js src/test/js/log-karaoke/parallelStages.js src/test/resources/test_scripts/parallel-stages.groovy http://jenkins-ci.org/commit/blueocean-acceptance-test/c15815cbf7dd7c3116e162a4322d9b7bf245e425 Log: FIX Jenkins-37962 REGRESSION: parallel karaoke not allowing branch selection or completing correctly (#42) JENKINS-37962 Add test for clicking on run button then on the emerging toast the open JENKINS-37962 Update comment to describe test case JENKINS-37962 better documentation of the steps

            People

              tscherler Thorsten Scherler
              michaelneale Michael Neale
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: