Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39874

Abilty to disable pipeline-replay in Job Configuration.

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      While the replay is good for debugging, it is also a huge security hole.

      Please allow users to disable this feature.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            For Declarative Pipeline only, there is a distinct ability to restart a build from a specified stage. It is similar to Rebuild (i.e., Replay without permission to modify scripts) but sets a special flag interpreted by the Declarative system to skip earlier stages.

            Show
            jglick Jesse Glick added a comment - For Declarative Pipeline only, there is a distinct ability to restart a build from a specified stage. It is similar to Rebuild (i.e., Replay without permission to modify scripts) but sets a special flag interpreted by the Declarative system to skip earlier stages.
            Hide
            jglick Jesse Glick added a comment -

            Oh and in case you were not confused enough today, CloudBees CI includes a checkpoint step which offers roughly analogous functionality to Scripted (but not Declarative) Pipelines.

            Show
            jglick Jesse Glick added a comment - Oh and in case you were not confused enough today, CloudBees CI includes a checkpoint step which offers roughly analogous functionality to Scripted (but not Declarative) Pipelines.
            Hide
            reinholdfuereder Reinhold Füreder added a comment - - edited

            *LOL* Thanks Jesse (especially for your humour): frankly, the confusion was certainly enough for me, so I waited till now before adding another (semi-important) comment

            => I trust you to find an acceptable solution – that is at least slightly better than the current confusing situation

            Show
            reinholdfuereder Reinhold Füreder added a comment - - edited *LOL* Thanks Jesse (especially for your humour): frankly, the confusion was certainly enough for me, so I waited till now before adding another (semi-important) comment => I trust you to find an acceptable solution – that is at least slightly better than the current confusing situation If "Rebuild" is supposed to stay, then your button renaming proposal according to https://issues.jenkins.io/browse/JENKINS-39874?focusedCommentId=405532&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-405532 is perfectly OK with me; I assume this applies to classic UI AND Blue Ocean UI...
            Hide
            jglick Jesse Glick added a comment -

            JENKINS-50855 pertains only to the “classic” UI. Blue Ocean is unrelated.

            Show
            jglick Jesse Glick added a comment - JENKINS-50855 pertains only to the “classic” UI. Blue Ocean is unrelated.
            Hide
            llibicpep Dmytro Kryvenko added a comment - - edited

            I have another use case that might or might not be common, but it certainly makes me want to have an ability to disable this feature. Not just on the level of user access - just disable it period.

            I have a groovy lib that generates a pipeline dsl dynamically and then evaluates it. It is being generated in chunks that are evaluated separately. When my team (who unlike my users - are jenkins admins by design having full access to everything) click Replay - due to the dynamic dsl generation they see 10+ text boxes with parts of the dsl. Because at Replay this dsl getting called outside of the proper context - it just fails. Replay just doesn't work for me and creating more issues than it solves. Not all of my team understands the way groovy lib and CPS works in Jenkins - most of them just configure jobs and by coincidence have access to the Replay feature. I wish I could completely disable Replay for our prod Jenkins instance just because it is buggy for us in the library context.

            Show
            llibicpep Dmytro Kryvenko added a comment - - edited I have another use case that might or might not be common, but it certainly makes me want to have an ability to disable this feature. Not just on the level of user access - just disable it period. I have a groovy lib that generates a pipeline dsl dynamically and then evaluates it. It is being generated in chunks that are evaluated separately. When my team (who unlike my users - are jenkins admins by design having full access to everything) click Replay - due to the dynamic dsl generation they see 10+ text boxes with parts of the dsl. Because at Replay this dsl getting called outside of the proper context - it just fails. Replay just doesn't work for me and creating more issues than it solves. Not all of my team understands the way groovy lib and CPS works in Jenkins - most of them just configure jobs and by coincidence have access to the Replay feature. I wish I could completely disable Replay for our prod Jenkins instance just because it is buggy for us in the library context.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              netsabes Sebastien Vas
              Votes:
              17 Vote for this issue
              Watchers:
              19 Start watching this issue

                Dates

                Created:
                Updated: