Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39905

Wrong path for on-premise BitbucketWeb source files

    XMLWordPrintable

Details

    • 4.7.2

    Attachments

      1. bitbucket_history_dropdown.png
        bitbucket_history_dropdown.png
        40 kB
      2. bitbucket_history.png
        bitbucket_history.png
        47 kB
      3. bitbucket-changes-url.JPG
        bitbucket-changes-url.JPG
        29 kB
      4. bitbucket-details.JPG
        bitbucket-details.JPG
        42 kB
      5. bitbucket-org-diff.png
        bitbucket-org-diff.png
        98 kB
      6. bitbucket-org-file-history.png
        bitbucket-org-file-history.png
        73 kB
      7. branch-source-with-repository-browser.png
        branch-source-with-repository-browser.png
        24 kB
      8. changes_page.png
        changes_page.png
        49 kB
      9. changes-with-hyperlinks.png
        changes-with-hyperlinks.png
        38 kB
      10. first_run.png
        first_run.png
        25 kB
      11. hover_link.png
        hover_link.png
        37 kB
      12. job_configuration.png
        job_configuration.png
        88 kB
      13. job_result.png
        job_result.png
        38 kB
      14. job-results-no-link-on-changed-file.png
        job-results-no-link-on-changed-file.png
        42 kB
      15. screenshot-1.png
        screenshot-1.png
        32 kB

      Activity

        mark_clark_jk Mark Clark added a comment -

        It has been a couple of years, so I don't know if this was the original cause of the problem. However, I contacted Atlassian/Bitbucket and was able to confirm that this behavior is related to the "New Source Browser Experience". When I disabled this feature (in the Bitbucket Labs page of my accounts settings), I was able to see the expected commit history of the specific file.

        It also appears that this is NOT the desired effect of the New Source Browser Experience. So I am expecting some time in the future, this will be fixed in Bitbucket and we will not need to disable New Source Browser Experience in order for this history link to work.

        mark_clark_jk Mark Clark added a comment - It has been a couple of years, so I don't know if this was the original cause of the problem. However, I contacted Atlassian/Bitbucket and was able to confirm that this behavior is related to the "New Source Browser Experience". When I disabled this feature (in the Bitbucket Labs page of my accounts settings), I was able to see the expected commit history of the specific file. It also appears that this is NOT the desired effect of the New Source Browser Experience. So I am expecting some time in the future, this will be fixed in Bitbucket and we will not need to disable New Source Browser Experience in order for this history link to work.

        PR #1071 was included in Git Plugin 4.7.2 and presumably fixes this. markewaite, can this issue be closed now?

        kon Kalle Niemitalo added a comment - PR #1071 was included in Git Plugin 4.7.2 and presumably fixes this. markewaite , can this issue be closed now?

        Bitbucket Server is the current name of the software that used to be called Stash. There are a few differences between BitbucketServer.java and Stash.java:

        • BitbucketServer.getDiffLink links to the per-commit page and selects the file from there, while Stash.getDiffLink links to the per-file page and selects the diff from there. OK, perhaps the per-commit page is better for showing that a file was renamed or deleted.
        • BitbucketServer.getFileLink does not add the commit ID as an "at" query parameter. That seems bad.
        • getDisplayName() of the descriptor returns "bitbucketserver" vs. "stash". OK.
        kon Kalle Niemitalo added a comment - Bitbucket Server is the current name of the software that used to be called Stash. There are a few differences between BitbucketServer.java and Stash.java : BitbucketServer.getDiffLink links to the per-commit page and selects the file from there, while Stash.getDiffLink links to the per-file page and selects the diff from there. OK, perhaps the per-commit page is better for showing that a file was renamed or deleted. BitbucketServer.getFileLink does not add the commit ID as an "at" query parameter. That seems bad. getDisplayName() of the descriptor returns "bitbucketserver" vs. "stash". OK.
        kon Kalle Niemitalo added a comment - - edited

        In general, you shouldn't test against Bitbucket Cloud if you want to know how things work in Bitbucket Data Center and Server. Although the names are confusingly similar, they are separate implementations in different programming languages.

        kon Kalle Niemitalo added a comment - - edited In general, you shouldn't test against Bitbucket Cloud if you want to know how things work in Bitbucket Data Center and Server. Although the names are confusingly similar, they are separate implementations in different programming languages.
        markewaite Mark Waite added a comment -

        Thanks for detecting that this issue can be closed kon. Much appreciated!

        markewaite Mark Waite added a comment - Thanks for detecting that this issue can be closed kon . Much appreciated!

        People

          Unassigned Unassigned
          forster_ch Christoph Forster
          Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: