Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40161

Allow StepExecution.onResume to throw Exception

    XMLWordPrintable

Details

    Description

      Proposal:

      Change onResume to throw Exception. (Would still be binary-compatible.) FlowExecutionList.ItemListenerImpl.onLoaded would then need to catch exceptions and call StepContext.onFailure. Like AbstractStepExecutionImpl, this would rely on transient fields holding the contextual object; the improvement would be that a failure in StepContext.get would stop anything else in onResume (such as the setupTimer methods in TimeoutStepExecution, SleepStep.Execution, or DurableTaskStep.Execution) from running.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37486 NPE: Failed to abort at org.jenkinsci.plugins.durabletask.FileMonitoringTask$FileMonitoringController.stop(FileMonitoringTask.java:167)

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-39134 com.google.inject.CreationException after resuming build in script {} or withMaven {}

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          links to

          Web Link workflow-api-plugin #187

          Activity

            People

              Unassigned Unassigned
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: