WorkflowJob.getSCMs() should have similar behaviour as poll()

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • Component/s: workflow-job-plugin
    • None
    • Environment:
      jenkins: 2.19.4
      workflow-job: 2.9

      The implementation of WorkflowJob.getSCMs() is troublesome. It uses the latest completed build to determine the SCM resource. Normally this works fine, however, if the last completed build has failed before all SCM resources was checked out, then none or not all SCM resources are returned. This is quite common for us since we, from time to time, have network problems and the SCM checkout step fails.
      So, I therefor suggest that getSCMs() first check if getLastSuccessfulBuild() returns a build, if not fall back by using getLastCompletedBuild().
      This behaviour is also more inline with WorkflowJob.poll() where it first check for a successful build.

            Assignee:
            Jon Sten
            Reporter:
            Jon Sten
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: