Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40652

origin pr builds not treated as trusted

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • github-branch-source-plugin
    • None
    • github-branch-source-plugin: 2.0.0-beta-1
      jenkins: 2.36

      When building PRs from origin (not forks), their Jenkinsfile is not treated as trusted and loaded from the base branch instead:

      Loading trusted files from base branch develop at 3ad383ee0eeffc92c9712dc8e3022c4b43a75c94 rather than 3e2b6e35cbf0fd2d4c029fcd23560f04b1976618

      Settings:

      [x] Build origin branches
      [x] Build origin PRs (unmerged head)

      IMHO any PR from origin should be treated as trusted. There is no issue with building their branches via "Build origin branches also filed as PRs".

          [JENKINS-40652] origin pr builds not treated as trusted

          Ryan Campbell added a comment - - edited

          Was this issue present in github-branch-source-plugin prior to 2.0?

          We are trying to determine if this is a regression introduced by the github-branch-source-plugin 2.0 beta releases.

          Ryan Campbell added a comment - - edited Was this issue present in github-branch-source-plugin prior to 2.0? We are trying to determine if this is a regression introduced by the github-branch-source-plugin 2.0 beta releases.

          Ryan Campbell added a comment -

          Provisionally marked as SCM 2.0 Upgrade Fallout until we determine otherwise.

          Ryan Campbell added a comment - Provisionally marked as SCM 2.0 Upgrade Fallout until we determine otherwise.

          Stephen Connolly added a comment -

          https://github.com/jenkinsci/github-branch-source-plugin/pull/114 is a minimal fix of the regression for merging into the 2.0.x upgrade fallout

          Stephen Connolly added a comment - https://github.com/jenkinsci/github-branch-source-plugin/pull/114 is a minimal fix of the regression for merging into the 2.0.x upgrade fallout

          Stephen Connolly added a comment -

          myoung34 I have created https://issues.jenkins-ci.org/browse/JENKINS-41522 to track the other changes in https://github.com/jenkinsci/github-branch-source-plugin/pull/109

          Stephen Connolly added a comment - myoung34 I have created https://issues.jenkins-ci.org/browse/JENKINS-41522 to track the other changes in https://github.com/jenkinsci/github-branch-source-plugin/pull/109

          marc young added a comment -

          stephenconnolly thanks so much!

          marc young added a comment - stephenconnolly thanks so much!

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/93d81cf26e8b46afdedf91c617c342b278257b4b
          Log:
          JENKINS-40652 Minimal fix for trusted revision

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/93d81cf26e8b46afdedf91c617c342b278257b4b Log: JENKINS-40652 Minimal fix for trusted revision

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/5607e401b9ac4b3f02b1c44e5b967630ad7b90b0
          Log:
          Merge pull request #114 from stephenc/jenkins-40652

          JENKINS-40652 Minimal fix for trusted revision

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/df02d731c5c1...5607e401b9ac

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/5607e401b9ac4b3f02b1c44e5b967630ad7b90b0 Log: Merge pull request #114 from stephenc/jenkins-40652 JENKINS-40652 Minimal fix for trusted revision Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/df02d731c5c1...5607e401b9ac

          Stephen Connolly added a comment -

          Marking this as fixed in github-branch-source-plugin 2.0.1-beta-5 but there are likely follow-up side issues being tracked in JENKINS-41522

          Stephen Connolly added a comment - Marking this as fixed in github-branch-source-plugin 2.0.1-beta-5 but there are likely follow-up side issues being tracked in JENKINS-41522

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/bb18410cff11efd7b21ccf4c55dfb6719bb61c12
          Log:
          JENKINS-40652 Late fix

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/bb18410cff11efd7b21ccf4c55dfb6719bb61c12 Log: JENKINS-40652 Late fix

          Stephen Connolly added a comment -

          scm-api-2.0.2
          git-2.6.4 or git-3.0.4
          branch-api-2.0.2
          bitbucket-branch-source-2.0.2
          github-branch-source-2.0.1
          cloudbees-folder-5.17
          workflow-multibranch-2.11

          Stephen Connolly added a comment - scm-api-2.0.2 git-2.6.4 or git-3.0.4 branch-api-2.0.2 bitbucket-branch-source-2.0.2 github-branch-source-2.0.1 cloudbees-folder-5.17 workflow-multibranch-2.11

            stephenconnolly Stephen Connolly
            chrono Martin Ringehahn
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: