Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40652

origin pr builds not treated as trusted

    XMLWordPrintable

Details

    Description

      When building PRs from origin (not forks), their Jenkinsfile is not treated as trusted and loaded from the base branch instead:

      Loading trusted files from base branch develop at 3ad383ee0eeffc92c9712dc8e3022c4b43a75c94 rather than 3e2b6e35cbf0fd2d4c029fcd23560f04b1976618

      Settings:

      [x] Build origin branches
      [x] Build origin PRs (unmerged head)

      IMHO any PR from origin should be treated as trusted. There is no issue with building their branches via "Build origin branches also filed as PRs".

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. JENKINS-41522 There is some good stuff in PR#109 that is extra from JENKINS-40652 and should be considered

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-37931 PR build can use PR's head/merge Jenkinsfile insted of master branch.

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-50290 origin pr builds not treated as trusted

          • Major - Major loss of function.
          • Open
          links to

          Web Link CloudBees Internal OSS-1913

          Web Link PR#114

          Activity

            Ascending order - Click to sort in descending order
            View 12 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/93d81cf26e8b46afdedf91c617c342b278257b4b
            Log:
            JENKINS-40652 Minimal fix for trusted revision

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/93d81cf26e8b46afdedf91c617c342b278257b4b Log: JENKINS-40652 Minimal fix for trusted revision
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/5607e401b9ac4b3f02b1c44e5b967630ad7b90b0
            Log:
            Merge pull request #114 from stephenc/jenkins-40652

            JENKINS-40652 Minimal fix for trusted revision

            Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/df02d731c5c1...5607e401b9ac

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/5607e401b9ac4b3f02b1c44e5b967630ad7b90b0 Log: Merge pull request #114 from stephenc/jenkins-40652 JENKINS-40652 Minimal fix for trusted revision Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/df02d731c5c1...5607e401b9ac
            stephenconnolly Stephen Connolly added a comment -

            Marking this as fixed in github-branch-source-plugin 2.0.1-beta-5 but there are likely follow-up side issues being tracked in JENKINS-41522

            stephenconnolly Stephen Connolly added a comment - Marking this as fixed in github-branch-source-plugin 2.0.1-beta-5 but there are likely follow-up side issues being tracked in JENKINS-41522
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/bb18410cff11efd7b21ccf4c55dfb6719bb61c12
            Log:
            JENKINS-40652 Late fix

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/bb18410cff11efd7b21ccf4c55dfb6719bb61c12 Log: JENKINS-40652 Late fix
            stephenconnolly Stephen Connolly added a comment -

            scm-api-2.0.2
            git-2.6.4 or git-3.0.4
            branch-api-2.0.2
            bitbucket-branch-source-2.0.2
            github-branch-source-2.0.1
            cloudbees-folder-5.17
            workflow-multibranch-2.11

            stephenconnolly Stephen Connolly added a comment - scm-api-2.0.2 git-2.6.4 or git-3.0.4 branch-api-2.0.2 bitbucket-branch-source-2.0.2 github-branch-source-2.0.1 cloudbees-folder-5.17 workflow-multibranch-2.11

            People

              stephenconnolly Stephen Connolly
              chrono Martin Ringehahn
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: