Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40662

Deep-linking to Run Details screen with no tab specified causes problem when closing modal

    XMLWordPrintable

Details

    • tethys, christmas

    Description

      Repro Steps:

      1. Deep link to a run details URL without specifying a tab, e.g. https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/task%2FJENKINS-40256-integrate-new-form-controls/2
      2. Close the modal

      Expected behavior:

      1. Activity tab displays recent runs

      Actual behavior:

      1. Header is displayed but there is no content beneath it

      Dev notes:
      This only happens when deeplinking to the general URL for the run without specifying a tab (e.g. /pipeline , /changes , etc). The UI issues a redirect to /pipeline but after closing the modal it doesn't update the URL correctly.

      We need to make the logic a bit more robust:

      1. May want to check history length when making determination on whether to go back or navigate to fallback URL
      2. May want to use history navigation rather than relying on the "opener URL"
      3. If possible, add a new API that simply "goes back" so that individual screens don't need to manage this. Creation flow could also use this.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. JENKINS-40972 REGRESSION: clicking result close from dashboard redirects to activity

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/main/js/custom_commands/waitForLocationChange.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/e703781bf42780531b03663871f89bc843166e95
            Log:
            JENKINS-40662 custom nightwatch command to watch for location changes, to avoid brittle use of pause

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/custom_commands/waitForLocationChange.js http://jenkins-ci.org/commit/blueocean-acceptance-test/e703781bf42780531b03663871f89bc843166e95 Log: JENKINS-40662 custom nightwatch command to watch for location changes, to avoid brittle use of pause
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
            src/test/js/edgeCases/runDetailsDeepLink.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/a7765b98907aed7b2eec00d37272f0c3adebffca
            Log:
            JENKINS-40662 add a test case for when user is deep-linked to run details in the URL form of :org/:pipeline/:branch/:runId and the modal doesn't close properly

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/edgeCases/runDetailsDeepLink.js http://jenkins-ci.org/commit/blueocean-acceptance-test/a7765b98907aed7b2eec00d37272f0c3adebffca Log: JENKINS-40662 add a test case for when user is deep-linked to run details in the URL form of :org/:pipeline/:branch/:runId and the modal doesn't close properly
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/cae8131418b0f060449fa389192250458f444aa2
            Log:
            JENKINS-40662 makes more sense to pause for location change any time the modal is closed as this will ensure downstream actions occur after the navigation is completed

            Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/e703781bf427^...cae8131418b0

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js http://jenkins-ci.org/commit/blueocean-acceptance-test/cae8131418b0f060449fa389192250458f444aa2 Log: JENKINS-40662 makes more sense to pause for location change any time the modal is closed as this will ensure downstream actions occur after the navigation is completed Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/e703781bf427 ^...cae8131418b0
            cliffmeyers Cliff Meyers added a comment -

            PR: https://github.com/jenkinsci/blueocean-plugin/pull/677

            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/677
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/main/js/custom_commands/index.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/136d7866cba51bace206d433a6ff2d589c63ffe6
            Log:
            JENKINS-40662 docs link

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/custom_commands/index.js http://jenkins-ci.org/commit/blueocean-acceptance-test/136d7866cba51bace206d433a6ff2d589c63ffe6 Log: JENKINS-40662 docs link
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/test/js/edgeCases/runDetailsDeepLink.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/00843f0362a27841ca32a6e5788d47c9093d1ef4
            Log:
            JENKINS-40662 avoid flakiness by waiting for job to finish

            Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/cae8131418b0...00843f0362a2

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/test/js/edgeCases/runDetailsDeepLink.js http://jenkins-ci.org/commit/blueocean-acceptance-test/00843f0362a27841ca32a6e5788d47c9093d1ef4 Log: JENKINS-40662 avoid flakiness by waiting for job to finish Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/cae8131418b0...00843f0362a2
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Cliff Meyers
            Path:
            src/main/js/custom_commands/index.js
            src/main/js/custom_commands/waitForLocationChange.js
            src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
            src/test/js/edgeCases/runDetailsDeepLink.js
            http://jenkins-ci.org/commit/blueocean-acceptance-test/6d1b8163d7f5a9894994ea1f31a31cef22082c13
            Log:
            Bug/jenkins 40662 run details close problem (#93)

            • JENKINS-40662 custom nightwatch command to watch for location changes, to avoid brittle use of pause
            • JENKINS-40662 add a test case for when user is deep-linked to run details in the URL form of :org/:pipeline/:branch/:runId and the modal doesn't close properly
            • JENKINS-40662 makes more sense to pause for location change any time the modal is closed as this will ensure downstream actions occur after the navigation is completed
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/custom_commands/index.js src/main/js/custom_commands/waitForLocationChange.js src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/edgeCases/runDetailsDeepLink.js http://jenkins-ci.org/commit/blueocean-acceptance-test/6d1b8163d7f5a9894994ea1f31a31cef22082c13 Log: Bug/jenkins 40662 run details close problem (#93) JENKINS-40662 custom nightwatch command to watch for location changes, to avoid brittle use of pause JENKINS-40662 add a test case for when user is deep-linked to run details in the URL form of :org/:pipeline/:branch/:runId and the modal doesn't close properly JENKINS-40662 makes more sense to pause for location change any time the modal is closed as this will ensure downstream actions occur after the navigation is completed JENKINS-40662 docs link JENKINS-40662 avoid flakiness by waiting for job to finish

            People

              cliffmeyers Cliff Meyers
              cliffmeyers Cliff Meyers
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: