-
Bug
-
Resolution: Fixed
-
Minor
-
None
When writing a Jenkinsfile, if you have email notifications, or notifications in general, this probably does not make sense to send those when building a PR. Same goes for actual deployments or touching real environments by any mean.
PR are reviewed through GitHub, have a build status there, and so on. So by default, sending emails to maintainers creates unnecessary noise.
Maybe this be globally enabled/disabled by default though the new options block.
Like:
options { notifyOnChangeRequest = true // I would argue that we should be opinionated and put it with a default of false }
And possibly be overridable per step, like:
notOnChangeRequest { // PR on GitHub & Bitbucket, patchset on Gerrit, Review Request in ReviewBoard... sh "deploy-to-production.sh" }
For when and usual stage deactivations:
when { branch CHANGE_REQUEST }
WDYT?
Thanks!
- relates to
-
JENKINS-42688 Provide a way to enable a post/* to run only under some context
-
- In Progress
-
- links to
Also:
As discussed on IRC, won't work because if the pipeline fails in early stages, then the stage with those notifications won't be reached anyway, hence the notifications never sent.