Oh, stages can have post steps. I forgot about that. That gives a workaround and also some guidance about structure.

It might go something like this:

pipeline {
    agent any
    stages {
        stage ("Prepare Dependencies") {
            steps {
                // Install dependencies
                sh 'npm install'
            }
        }
        stage ("Build") {
            steps {
                echo 'Execute build that creates artifacts'
            }
            post {
               success {
                    archive 'output/**'
                }
               always {
                    archive 'logs/**'
                }
            }
        }
        stage ("Test") {
            steps {
                echo 'Execute build that creates artifacts'
            }
            post {
               always {
                    junit 'reports/**'
                }
            }
        }
    }
    post {
        always {
            echo "send email to people with final build status"
        }
    }
}

Cool, I can live with this.

The workaround mentioned here doesn't work for me. Are there any plans to address this issue?

Currently, I have to use

post { always { catchError { ... } cleanWs() } }

everywhere to make sure I always clean up my workspaces. This workaround introduces another bug, though: Incorrect archiveArtifacts configurations in the catchError block will be completely ignored.

When I discovered this problem, my first instinct was to add a second always closure, but Jenkins didn't accept that. Maybe allowing this would be a good solution to the underlying problem?

Edit: Sorry, completely missed that this is already mentioned above.

I've got a PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/258 that adds a new post condition, currently called cleanup, which runs regardless of build status but after all the other conditions have resolved.

abayer thank you very much! While it doesn't fix the original issue, it very much fixes my use case. Especially the fact that `always` ran before `success` was giving me headaches.

Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Cleanup.groovy
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Messages.properties
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BuildConditionResponderTest.java
pipeline-model-definition/src/test/resources/postChecksAllConditions.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/83abd0ec35960c1f2a37b6a66b2d26385b2962e2
Log:
[FIXED JENKINS-41239] Add new cleanup post condition

The new `cleanup` condition will always run regardless of build
status, like `always`, but runs after all other `post` conditions
have been evaluated, rather than before.

I wanted to call this `finally` but that actually breaks Groovy
parsing because `finally` is a reserved word. Dang. So for now, I'm
calling it `cleanup`, but am open to suggestions.

Merged, releasing later today in Declarative 1.2.9

Code changed in jenkins
User: Andrew Bayer
Path:
content/doc/book/pipeline/syntax.adoc
http://jenkins-ci.org/commit/jenkins.io/c8c7bce2e7c5955d5176f0791800156cf0c087a2
Log:
JENKINS-41239 Add doc for new cleanup post condition.

This was just released in Declarative 1.2.9 so this should be ready to
go whenever works for you.

Code changed in jenkins
User: R. Tyler Croy
Path:
content/doc/book/pipeline/syntax.adoc
http://jenkins-ci.org/commit/jenkins.io/5c434e826c79dc06f837a6d244c9ddf5df1fa382
Log:
Merge pull request #1504 from abayer/jenkins-41239

JENKINS-41239 Add doc for new cleanup post condition.

Compare: https://github.com/jenkins-infra/jenkins.io/compare/92e468e7f66b...5c434e826c79

Bulk closing resolved issues.