Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41453

All pull requests are migrated to Branches on upgrade to 2.0.1-beta-2

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:

      Description

      Migration of SCMHead instances was too generic

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41133 Github Pull Requests showing up under Branches

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link github-branch-source-plugin#112

          Web Link scm-api-plugin#25

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/scm/api/SCMHeadMigration.java
            http://jenkins-ci.org/commit/scm-api-plugin/fc32e1df3f5c03701d87e432445ef636ef05cd02
            Log:
            JENKINS-41453 Migration code was overly zealous

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMHeadMigration.java http://jenkins-ci.org/commit/scm-api-plugin/fc32e1df3f5c03701d87e432445ef636ef05cd02 Log: JENKINS-41453 Migration code was overly zealous
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/scm/api/SCMHeadMigration.java
            http://jenkins-ci.org/commit/scm-api-plugin/06fe724e36edd2ac13328cb94aa38d6e59b4333a
            Log:
            Merge pull request #25 from stephenc/jenkins-41453

            JENKINS-41453 Migration code was overly zealous

            Compare: https://github.com/jenkinsci/scm-api-plugin/compare/a57e75191ff0...06fe724e36ed

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMHeadMigration.java http://jenkins-ci.org/commit/scm-api-plugin/06fe724e36edd2ac13328cb94aa38d6e59b4333a Log: Merge pull request #25 from stephenc/jenkins-41453 JENKINS-41453 Migration code was overly zealous Compare: https://github.com/jenkinsci/scm-api-plugin/compare/a57e75191ff0...06fe724e36ed
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/5f102ac6970b8d43838ca44306ef530e968c07d7
            Log:
            JENKINS-41453 Fix fallout from fixing the overzealous migration of heads

            • The pull requests are missing semi-required information and we need to migrate the key fields to prevent a build storm
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java http://jenkins-ci.org/commit/github-branch-source-plugin/5f102ac6970b8d43838ca44306ef530e968c07d7 Log: JENKINS-41453 Fix fallout from fixing the overzealous migration of heads The pull requests are missing semi-required information and we need to migrate the key fields to prevent a build storm
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/04636a5028edccfd4b93dfbf7a93d6c171eccb1d
            Log:
            [FIXED JENKINS-41453] Pick up the scm-api 2.0.2-beta-2

            • Also address code review comments
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java http://jenkins-ci.org/commit/github-branch-source-plugin/04636a5028edccfd4b93dfbf7a93d6c171eccb1d Log: [FIXED JENKINS-41453] Pick up the scm-api 2.0.2-beta-2 Also address code review comments
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/e05ea33fe7e1ffdd02911c9b284d1fff5f48addf
            Log:
            JENKINS-41453 sourceOwner != pull request user and add ContributorMetadataAction for PRs

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java http://jenkins-ci.org/commit/github-branch-source-plugin/e05ea33fe7e1ffdd02911c9b284d1fff5f48addf Log: JENKINS-41453 sourceOwner != pull request user and add ContributorMetadataAction for PRs
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
            src/test/resources/api/__files/body-users-stephenc-JRfTU.json
            src/test/resources/api/mappings/mapping-users-stephenc-JRfTU.json
            http://jenkins-ci.org/commit/github-branch-source-plugin/d775b6772a28f9033fd593c997f6e264b8c3038b
            Log:
            Merge pull request #113 from stephenc/jenkins-41453-follow-up

            JENKINS-41453 sourceOwner != pull request user and add ContributorMetadataAction for PRs

            Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/1e6f8f659bb8...d775b6772a28

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java src/test/resources/api/__files/body-users-stephenc-JRfTU.json src/test/resources/api/mappings/mapping-users-stephenc-JRfTU.json http://jenkins-ci.org/commit/github-branch-source-plugin/d775b6772a28f9033fd593c997f6e264b8c3038b Log: Merge pull request #113 from stephenc/jenkins-41453-follow-up JENKINS-41453 sourceOwner != pull request user and add ContributorMetadataAction for PRs Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/1e6f8f659bb8...d775b6772a28
            Hide
            Permalink
            stephenconnolly Stephen Connolly added a comment -

            scm-api-2.0.2
            git-2.6.4 or git-3.0.4
            branch-api-2.0.2
            bitbucket-branch-source-2.0.2
            github-branch-source-2.0.1
            cloudbees-folder-5.17
            workflow-multibranch-2.11

            Show
            stephenconnolly Stephen Connolly added a comment - scm-api-2.0.2 git-2.6.4 or git-3.0.4 branch-api-2.0.2 bitbucket-branch-source-2.0.2 github-branch-source-2.0.1 cloudbees-folder-5.17 workflow-multibranch-2.11

              People

              Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: